Skip to content

fix(cli): keep test variant names longer than 64 characters - #1361

Merged
trunk-io[bot] merged 1 commit into
mainfrom
matt/variant-no-64-limit
Nov 18, 2026
Merged

trunk-io[bot] merged 1 commit into
mainfrom
matt/variant-no-64-limit

Conversation

@mmatheson

Copy link
Copy Markdown
Member

The CLI no longer cuts --variant to 64 characters. Long variant names now go to the server as they are.

The problem: Different long variants become one variant after the cut, so their flaky-test history mixes. 10gen/mongo sends Evergreen build variant names, and many are longer than 64 characters. For example, ...-extra-system-deps, ...-extra-system-deps-sharded-clusters and ...-extra-system-deps-fuzzers all become enterprise-amazon-linux2023-arm64-all-feature-flags-extra-system. In the last 7 days, 30 cut variants on 10gen/mongo are affected. Also, the cut is by byte, so a non-ASCII name can crash the CLI.

The fix: Remove the limit. I did not add a larger limit. The servers keep any length (trunk2 keeps the variant as a string, and the ClickHouse columns are String), and no other part of the CLI, bundle or context limits it. A new limit would only move the same problem to a different length. The test now checks a 64-character name, a long Evergreen name and a long non-ASCII name.

Side effect: The test id includes the variant. Tests on variants longer than 64 characters get new ids, and their history starts again. This affects:

  • 10gen/mongo (repo f7740537-4075-4a94-8019-3eed39a759c6). It has about one day of history now.
  • Maybe repo dcf9eb51-cf4b-4bdc-8bc1-a2040fdbe8f4. It has one variant that is exactly 64 characters, so its real name may be longer.

Tests: cargo test -p trunk-analytics-cli passes, except 3 Swift xunit tests in cli/tests/upload.rs. These 3 tests also fail on main in my sandbox, so this change does not cause them.

Linear: TRUNK-24255

🤖 Generated with Claude Code

…255)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@trunk-io
trunk-io Bot merged commit 02ba802 into main Nov 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants