Repository navigation
fix(cli): keep test variant names longer than 64 characters - #1361
Merged
Merged
Conversation
…255) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
acatxnamedvirtue
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI no longer cuts
--variantto 64 characters. Long variant names now go to the server as they are.The problem: Different long variants become one variant after the cut, so their flaky-test history mixes. 10gen/mongo sends Evergreen build variant names, and many are longer than 64 characters. For example,
...-extra-system-deps,...-extra-system-deps-sharded-clustersand...-extra-system-deps-fuzzersall becomeenterprise-amazon-linux2023-arm64-all-feature-flags-extra-system. In the last 7 days, 30 cut variants on 10gen/mongo are affected. Also, the cut is by byte, so a non-ASCII name can crash the CLI.The fix: Remove the limit. I did not add a larger limit. The servers keep any length (trunk2 keeps the variant as a string, and the ClickHouse columns are
String), and no other part of the CLI,bundleorcontextlimits it. A new limit would only move the same problem to a different length. The test now checks a 64-character name, a long Evergreen name and a long non-ASCII name.Side effect: The test id includes the variant. Tests on variants longer than 64 characters get new ids, and their history starts again. This affects:
f7740537-4075-4a94-8019-3eed39a759c6). It has about one day of history now.dcf9eb51-cf4b-4bdc-8bc1-a2040fdbe8f4. It has one variant that is exactly 64 characters, so its real name may be longer.Tests:
cargo test -p trunk-analytics-clipasses, except 3 Swift xunit tests incli/tests/upload.rs. These 3 tests also fail onmainin my sandbox, so this change does not cause them.Linear: TRUNK-24255
🤖 Generated with Claude Code