Skip to content

fix(cli): log a missing GitHub Actions external ID as a warning - #1367

Merged
trunk-io[bot] merged 1 commit into
mainfrom
tylerbeebe/github-external-id-warn
Nov 18, 2026
Merged

trunk-io[bot] merged 1 commit into
mainfrom
tylerbeebe/github-external-id-warn

Conversation

@acatxnamedvirtue

Copy link
Copy Markdown
Contributor

When analytics-cli can't find the GitHub Actions job ID, it now logs a warning, not an error. A warning goes to Sentry as a breadcrumb, not an event.

The CLI reads the ID from the runner's _diag/Worker_*.log, which it finds through the Runner.Worker process. In container jobs and on some self-hosted runners that process isn't visible, so the lookup fails on every upload. Each failure became a Sentry event: ANALYTICS-CLI-4M9, about 3M events (TRUNK-17780). The upload itself is unaffected; only GITHUB_EXTERNAL_ID is left out.

In production over the last 7 days, 442k of 1.22M GitHub Actions uploads had no external ID. They come from 46 collections, and each of those collections is missing it on every upload.

🤖 Generated with Claude Code

The CLI cannot see the runner's Runner.Worker process in container jobs and on
some self-hosted runners, so every upload there sent a Sentry event
(ANALYTICS-CLI-4M9, about 3M events). The upload is unaffected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@trunk-io
trunk-io Bot merged commit 9879981 into main Nov 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants