Repository navigation
fix(cli): log a missing GitHub Actions external ID as a warning - #1367
Merged
Merged
Conversation
The CLI cannot see the runner's Runner.Worker process in container jobs and on some self-hosted runners, so every upload there sent a Sentry event (ANALYTICS-CLI-4M9, about 3M events). The upload is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
acatxnamedvirtue
requested review from
TylerJang27,
dfrankland and
max-trunk
November 18, 2026 21:13
TylerJang27
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When analytics-cli can't find the GitHub Actions job ID, it now logs a warning, not an error. A warning goes to Sentry as a breadcrumb, not an event.
The CLI reads the ID from the runner's
_diag/Worker_*.log, which it finds through theRunner.Workerprocess. In container jobs and on some self-hosted runners that process isn't visible, so the lookup fails on every upload. Each failure became a Sentry event: ANALYTICS-CLI-4M9, about 3M events (TRUNK-17780). The upload itself is unaffected; onlyGITHUB_EXTERNAL_IDis left out.In production over the last 7 days, 442k of 1.22M GitHub Actions uploads had no external ID. They come from 46 collections, and each of those collections is missing it on every upload.
🤖 Generated with Claude Code