Skip to content

fix(upkeep): paginate normalized check runs - #81

Merged
trvny merged 1 commit into
mainfrom
fix/upkeep-check-run-pagination-20261110
Nov 10, 2026
Merged

trvny merged 1 commit into
mainfrom
fix/upkeep-check-run-pagination-20261110

Conversation

@trvny

@trvny trvny commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Fix

Octokit's paginate() already unwraps check_runs into response.data. The extra mapper returned undefined, so Dependabot PRs crashed when upkeep read run.status.

Remove the redundant mapper; preserve all existing merge safety checks and token scopes.

Verification

  • Confirmed against Octokit's documented pagination contract.
  • Reproduced the failure path from Actions run #42751458020 (Autka, trvny, WiFi-Automatic).

View guided diff Turn on auto-fix

Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
@kanarek-companion

kanarek-companion Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🐤 Kanarek · 🟣 merged

main ✅

It landed in main. Kanarek closes the notebook.

Kanarek · 1 files

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

checkState 移除了从分页响应中提取 check_runs 数组的映射函数。现在由 Octokit 默认映射处理分页结果。

Merge Risk: Minimal · up to aeba3

This small fix stops the upkeep script from crashing on Dependabot PRs by using the normalized check-run list that Octokit already returns. No merge-blocking risk was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed 标题准确概括了主要变更:修复 upkeep 中规范化 check runs 的分页处理。
Description check Passed 描述说明了冗余 mapper 导致的故障及其修复,与变更内容相关。
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

小小映射退场去
Octokit 接过分页尺
check_runs 不再单独取
默认结果来相聚
检查运行稳步行
石头人点头说好!

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T11:28:29.060460Z aeba359 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@trvny
trvny merged commit c093534 into main Nov 10, 2026
9 checks passed
@trvny
trvny deleted the fix/upkeep-check-run-pagination-20261110 branch November 10, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant