[fix][plat] Allow for npm registry env vars to be set - #364
Merged
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| charts/retool/templates/deployment_agent_sandbox.yaml | Adds proxy npm-registry environment variables, but permits a named Secret with an empty key, which prevents the proxy pod from starting. |
| charts/retool/values.yaml | Defines the npm-registry configuration surface, but omits the required matching update to the root values.yaml and therefore fails the synchronization workflow. |
Reviews (1): Last reviewed commit: "[fix][plat] Allow for npm registry env v..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ryanartecona
approved these changes
Aug 17, 2026
Comment on lines
+783
to
+785
| {{- if and $npm.authTokenSecret.name (not $npm.authTokenSecret.key) -}} | ||
| {{- fail "agentSandbox.proxy.npmRegistry.authTokenSecret.name is set without .key, which would render an empty secretKeyRef and leave the proxy unable to start. Set .key to the entry holding the registry token." -}} | ||
| {{- end -}} |
Contributor
There was a problem hiding this comment.
maybe worth another check here to fail if $npm.authToken and $npm.authTokenSecret.name are both set, since the secret won't get used at all in that case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds easy setting of npm registry settings for the agent executor proxy.