Repository navigation
Conversation
pad_def declared w and h with no defaults and pad() read them straight
off the params, so fp.string("pad") crashed with a raw TypeError from
mm(undefined). The sibling smtpad defaults to a 1mm pad, so give pad
the same 1mm default and parse the def so bare-name usage renders.
Fixes tscircuit#788
Author
|
Friendly maintainer review request: this contribution has been updated with the latest fixes and checks. Please review when convenient. Thank you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788
Summary
padis advertised bygetFootprintNames(), butfp.string("pad")crashed with a rawTypeError: undefined is not an object (evaluating 'n.replace')leaking@tscircuit/mminternals:pad_defdeclaredw/hwith no defaults andpad()read them straight off the params without parsing.Changes
pad_def: givewandha1mmdefault, matching the siblingsmtpadbehavior (else width = mm("1mm"))pad(): parse params throughpad_defso the defaults actually apply, and return the parsed parametersTesting
tests/pad-bare-name.test.ts: barepadrenders a 1mm pad (previously crashed), explicitpad_w2mm_h1mmstill winsbun test tests/pad-bare-name.test.ts tests/pad.test.tspasses; existingpadsnapshot unchanged