Repository navigation
Conversation
vson declared p/w/grid/pinw/pinh with no defaults ("can't use defaults
because there is not a lot of common dimensions"), so any bare vsonN
name — which getFootprintNames() advertises — threw a raw ZodError
while the son/wson siblings render from their bare names.
Default to a common 3x3mm-body VSON-8: 0.5mm pitch, 2.75mm row
separation (pads tucked under the body edges), 0.25x0.6mm pin pads.
grid.x must stay <= w + pinw for the stepped courtyard helper, which
the defaults satisfy. Explicit parameters still win.
Fixes tscircuit#782
Author
|
Friendly maintainer review request: this contribution has been updated with the latest fixes and checks. Please review when convenient. Thank you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #782
Summary
vsonis listed bygetFootprintNames(), but any barevsonNname threw a raw ZodError (Required: p, w, grid, pinw, pinh) while the sibling SON-family footprints (son,wson) render from their bare names. The def carried a comment "can't use defaults because there is not a lot of common dimensions", leaving advertised names uncallable.Changes
Default to a common 3x3mm-body VSON-8:
p: 0.5mm pitchw: 2.75mm row separation (pads tucked under the body edges)grid: 3x3mmpinw/pinh: 0.25mm x 0.6mmgrid.x <= w + pinwis required by the stepped-courtyard helper (createRectUnionOutline), and the defaults satisfy it. Explicit parameters still win.Testing
tests/vson-bare-name.test.ts: barevson8renders 8 pads in two 4-pad rows at the expected pitch/separation/pad size, barevsondefaults to 8 pins, and explicit dimensions override the defaults