Promo recorder runs from a fresh install - #10
Merged
Merged
Conversation
From the review on #9. - playwright was imported but not declared, so `bun promo/record.mjs` failed after a fresh install. It is a dev dependency now; the browser is still a separate one-off download, noted at the top of the script. - The page's file URL is built with pathToFileURL, so a folder named with #, ? or % stays a path. - The PROMO_DIR override is gone: it existed only to run the script from outside the repo while playwright was missing.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review on #9. Tooling only; nothing in the extension changes.
playwrightwas imported bypromo/record.mjsbut not declared, so the script failed after a freshbun install. It is a dev dependency now. The browser is still a separate one-off download (bunx playwright install chromium), noted at the top of the script, so CI and ordinary installs fetch nothing extra.pathToFileURL, so a folder named with#,?or%stays a path.PROMO_DIRoverride is removed. It only existed to run the script from outside the repo while playwright was missing.Checked by running
bun promo/record.mjs simplefrom the repo: it renderedpromo/sharp-simple.mp4. 125 tests pass;bun run checkis clean.