Skip to content

Handle nil input in split #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benonymus wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Handle nil input in split #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982b2d8
Handle nil input in split
benonymus Apr 27, 2026
69925e8
Update standard.ex
benonymus Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions lib/expression/callbacks/standard.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,6 +1177,7 @@ defmodule Expression.Callbacks.Standard do
Defaults to split the string using a space.
"""
@expression_category "string"
@expression_doc expression: "split(nil)", result: []
@expression_doc expression: "split(\"testing something\")", result: ["testing", "something"]
@expression_doc expression: "split(\"testing something\", \"e\")",
result: ["t", "sting som", "thing"]
Expand Down Expand Up @@ -1205,12 +1206,26 @@ defmodule Expression.Callbacks.Standard do
}
},
result: ["t", "sting som", "thing"]
def split(ctx, binary),
do: String.split(eval!(binary, ctx), " ")
def split(ctx, binary) do
text = eval!(binary, ctx)

if is_nil(text) do
[]
else
String.split(text, " ")
end
end

@expression_category "string"
def split(ctx, binary, pattern),
do: String.split(eval!(binary, ctx), eval!(pattern, ctx))
def split(ctx, binary, pattern) do
text = eval!(binary, ctx)

if is_nil(text) do
[]
else
String.split(text, eval!(pattern, ctx))
end
end

@doc """
Returns the sum of all arguments, equivalent to the + operator
Expand Down