[ci] Upgrade Expression to 3.0.0-rc - #312
Conversation
|
mostly a PR to see what the fall-out is from the breaking changes in the 3.X.X release candidates. |
santiagocardo
left a comment
There was a problem hiding this comment.
LGTM, thanks @smn 🚀
|
Cool. Before merging I'm going to be creating a PR in our product to see what the test fall out could be. |
|
👋 Hi! When I run our flow tester with this branch, the debug output for template messages doesn't evaluate the language code. For example, we get |
|
@jerith thanks! Yeah that's likely because we no longer automatically expand nested expressions anymore. I'll get a fix in to the flow runner for this because I don't think here that's a worthwhile breaking change. |
|
@jerith I've got a fix in for your issue but not entirely happy with it, that said, could you review it? |
|
latest expression now handles nested evaluations, it was a mistake to remove that. |
|
@jerith pls run against your stuff and see what breaks ? |
There was a problem hiding this comment.
@smn, just a heads-up: changes here may be ported to the new simulator implementation in the product.
|
Looks like it's working after three changes to our code:
All of these are specific to our code and look like improvements to me. Thanks! 🎉 |
|
thanks @jerith - that's good to hear |
Summary
expressiondependency from hex~> 2.48.0to therelease/3-0-0branch on GitHub (3.0.0-rc)FlowRunnerandDynamicSelectOneResponseto useExpressiondirectly instead of the removedExpression.V2.Compatmoduleelixir.yml,releases.yml,cla.yml) to full-length commit SHAs to comply with org security policyChanges
github: "turnhub/expression", branch: "release/3-0-0"Expression.V2.Compatcalls withExpressionmodule; adaptevaluate_expression_block/2for new{:ok, val}/{:error, reason}return typeExpression.V2.Compat→Expressionmigrationactions/checkout,erlef/setup-beam,actions/cache,mikepenz/action-junit-report, andcontributor-assistant/github-actionto commit SHAsTest plan
🤖 Generated with Claude Code