fix: avoid deprecated aiohttp basic auth API - #944
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Encode asynchronous Basic Auth credentials as an Authorization header without using aiohttp’s deprecated BasicAuth request path. Preserve the SDK’s aiohttp 3.8.4 compatibility, Latin-1 wire encoding, validation, and header-conflict behavior. Signed-off-by: sama Pyb <peiyibopybsama@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #931
Replace the deprecated aiohttp
BasicAuth/auth=request path with anAuthorizationheader inAsyncTwilioHttpClient.The implementation feature-detects
encode_basic_authso the declaredaiohttp>=3.8.4range remains supported, explicitly preserves the historical Latin-1 wire encoding, rejects conflicting Authorization headers case-insensitively, and does not mutate caller-provided headers. The network call no longer passes theauthkeyword, which also avoids the second aiohttp 3.14 deprecation and remains compatible with its planned removal in aiohttp 4.Validation
make analysis: passedgit diff --check: passedmake testreaches the repository-wide Black check and stops on the pre-existing formatting oftests/unit/rest/test_client.py. That file is unchanged frommain; the complete pytest suite and both Flake8 commands were run separately as listed above.Checklist