Repository navigation
Conversation
marchcat
force-pushed
the
fix/apps-submenu
branch
from
October 21, 2026 22:12
e32338e to
4c03723
Compare
Include existing application candidates when the menu's provider is apps. Preserve static menu children and their browsing order, and rank combined search results with the existing enablement and metadata handling. Add regression coverage for provider overrides, custom children, search, aliases, and frecency.
marchcat
force-pushed
the
fix/apps-submenu
branch
from
October 22, 2026 21:02
4c03723 to
94afae6
Compare
cpreston321
added a commit
to cpreston321/oma-cast
that referenced
this pull request
Oct 26, 2026
Author
|
Closing this because the issue this PR targeted concerned the Apps submenu on Omarchy 4.0. The submenu was tested in isolation, while on my current Omarchy 4.5 setup the Apps entry opens Omarchy’s app grid directly. Current oma-cast also falls back to the Omarchy menu for unsupported providers. Thanks for maintaining the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Apps submenu showing no installed applications.
Applications already exist in the launcher’s candidate list with
app:IDs,but submenu selection only matched
omarchy:<menuId>.*children, leaving application candidates out.Changes
provider: "apps", rather than relying on the menu ID.The production change is limited to
submenuSections(). Application discovery, launching, and root-search ranking are unchanged.Testing
node --test tests/— all 76 tests pass.How to verify