Skip to content

Populate the Apps submenu - #17

Closed
marchcat wants to merge 1 commit into
typecraft-dev:mainfrom
marchcat:fix/apps-submenu
Closed

marchcat wants to merge 1 commit into
typecraft-dev:mainfrom
marchcat:fix/apps-submenu

Conversation

@marchcat

Copy link
Copy Markdown

Summary

Fixes the Apps submenu showing no installed applications.

Applications already exist in the launcher’s candidate list with app: IDs,
but submenu selection only matched omarchy:<menuId>.* children, leaving application candidates out.

Changes

  • Include existing application candidates when the active menu declares provider: "apps", rather than relying on the menu ID.
  • Preserve static menu children and their declared order when browsing.
  • Use the existing ranker for applications and combined submenu search results, retaining disabled-state filtering, aliases, and frecency.

The production change is limited to submenuSections(). Application discovery, launching, and root-search ranking are unchanged.

Testing

  • node --test tests/ — all 76 tests pass.
  • Regression coverage includes application listing and search, provider overrides, custom children, menu ordering, aliases, frecency, and disabled applications.
  • Verified locally in the running Omarchy plugin.

How to verify

  1. Open the Apps submenu in oma-cast.
  2. Confirm installed applications appear without entering a query.
  3. Search for an installed application and confirm matching results appear.
  4. Check that ordinary Omarchy submenus still display their children normally.

Include existing application candidates when the menu's provider is apps.
Preserve static menu children and their browsing order, and rank combined
search results with the existing enablement and metadata handling.

Add regression coverage for provider overrides, custom children, search,
aliases, and frecency.
cpreston321 added a commit to cpreston321/oma-cast that referenced this pull request Oct 26, 2026
@marchcat

marchcat commented Oct 30, 2026 •

Copy link
Copy Markdown
Author

Closing this because the issue this PR targeted concerned the Apps submenu on Omarchy 4.0. The submenu was tested in isolation, while on my current Omarchy 4.5 setup the Apps entry opens Omarchy’s app grid directly. Current oma-cast also falls back to the Omarchy menu for unsupported providers. Thanks for maintaining the project!

@marchcat marchcat closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant