Repository navigation
Fix numpad typing in launcher - #21
Open
amanmprojects wants to merge 1 commit into
Open
amanmprojects wants to merge 1 commit into
amanmprojects wants to merge 1 commit into
Conversation
Ignore Qt's keypad flag when checking printable text. Add CI regressions for keypad digits, operators, alias and action filtering, and shortcut dispatch without changing the calculator. Co-Authored-By: Claude Code <noreply@anthropic.com>
amanmprojects
force-pushed
the
fix/numpad-input
branch
from
October 22, 2026 17:52
8e3ffd3 to
ba5497c
Compare
cpreston321
added a commit
to cpreston321/oma-cast
that referenced
this pull request
Oct 26, 2026
cpreston321
added a commit
to cpreston321/oma-cast
that referenced
this pull request
Oct 26, 2026
The test's mock window predated the action-panel key, navigation bindings and editor views. It now extracts those helpers from LauncherWindow.qml too, so the numpad paths run the real routing.
cpreston321
added a commit
to cpreston321/oma-cast
that referenced
this pull request
Oct 26, 2026
…ueries The query is now a native TextInput, so typing moves out of handleKey. Resolution: keep the fork's guard against popping an empty quicklink form on Backspace, and cap the input at a script prompt's maxLength (setQuery refuses longer text, which the field would otherwise show). typecraft-dev#21 and typecraft-dev#26 both added tests/launcher-input.test.js. It is now typecraft-dev#26's, with the editor helpers its alias test routes through; typecraft-dev#21's numpad tests move to tests/launcher-keypad.test.js, where printable numpad keys in the query now pass through to the native input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix numpad typing
Numpad digits and
+ - / *were discarded because Qt includesKeypadModifierin their events, while the launcher's printable-text check accepted only no modifier or Shift.Ignore only the keypad flag when checking text input. This fixes root queries, aliases and action-panel filters while preserving Enter and Ctrl/Alt/Meta shortcut handling.
Rebased onto current upstream
main(90efedd). Extracts the input fix discovered in #16; no calculator replacement, runtime dependencies, desktop configuration changes or host-compatibility changes.Verification
node --test tests/*.test.js: 95 passed on the rebased branch, including seven launcher-input regressions. I re-ran the same test file against unpatchedmain: 4 passed, 3 failed, so the regressions do catch the bug.isTypingandhandleKeyfunctions from QML with Qt constants and stubbed UI actions, so they run in the existing Node CI without requiring a desktop.2+3*4-6/2+0.5afterward. That live check used Add inline calculator to root search (Phase 2) #16's branch. A fresh upstream-native window check was blocked on this machine by its pre-existing Omarchy host-type incompatibilities; those are outside this patch.🤖 Generated with Claude Code