Skip to content

Ignore .venv, add CI, fix stale ellphi-alpha paths - #3

Merged
uda-lab-agent merged 2 commits into
mainfrom
issue-1-venv-ci-paths
Oct 2, 2026
Merged

uda-lab-agent merged 2 commits into
mainfrom
issue-1-venv-ci-paths

Conversation

@uda-lab-agent

Copy link
Copy Markdown
Contributor

Summary

  • Add .venv/ to .gitignore (previously only hidden locally via .git/info/exclude).
  • Add .github/workflows/ci.yml: Python 3.10/3.11/3.12 matrix running pytest; gudhi is installed only on the 3.12 leg so the GUDHI-dependent tests run there (they self-skip without it per tests/test_phase4_baseline.py).
  • Fix stale ellphi-alpha/old-URL references left from the repo rename to ellcech: AGENTS.md scope line, README's cd ellphi-alpha install step, pyproject.toml homepage URL. The importable package name ellphi_alpha (and the pyproject.toml name = "ellphi-alpha" project name) is unchanged per the issue scope.

CI installer choice

The repo uses Poetry, but its demo optional group bundles gudhi together with jupyterlab/ipykernel/matplotlib/pandas/tqdm. Installing that whole group just to get gudhi on one CI leg would be slow and install unrelated heavy packages. Per the issue's allowance, CI instead uses pip install -e . (pulls the [project.dependencies] — numpy, scipy, ellphi) plus pip install pytest pytest-cov, and a standalone pip install gudhi on the 3.12 leg only. Poetry/uv migration is out of scope here (tracked separately as ellcech#2).

Validation

$ .venv/bin/python -m pytest -q
178 passed in 38.85s

(run with gudhi 3.13.0 present in the local .venv, so GUDHI-dependent tests executed, not skipped)

Closes #1

🤖 Generated with Claude Code

https://claude.ai/code/session_01C4X65cXZarMEDtKzEP98rX

- Add .venv/ to .gitignore so a local venv does not need
  .git/info/exclude tricks.
- Add .github/workflows/ci.yml: Python 3.10-3.12 matrix running
  pytest, with gudhi installed only on the 3.12 leg so the
  GUDHI-dependent tests run there (they self-skip otherwise).
  Uses `pip install -e .` rather than Poetry: the Poetry "demo"
  group bundles gudhi together with jupyterlab/matplotlib/pandas,
  which would make a gudhi-only CI leg slow; pip install -e . plus
  a standalone `pip install gudhi` keeps that leg fast. Package
  management migration (uv) is out of scope (ellcech#2).
- Fix stale ellphi-alpha directory/URL references left over from
  the repo rename to ellcech: AGENTS.md scope line, README's
  `cd ellphi-alpha` install step, and pyproject.toml homepage URL.
  The importable package name `ellphi_alpha` is unchanged.

Closes #1

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4X65cXZarMEDtKzEP98rX
@t-uda

t-uda commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@codex please review this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T14:22:20.533207Z 38701a4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5bc50ea4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml Resolved
Comment thread pyproject.toml Resolved
A bare homepage key under [project] is not part of PEP 621 and is
not emitted as a Project-URL in package metadata. Move it to
[project.urls] so the corrected URL actually reaches package
metadata consumers (PyPI, pip show, etc).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4X65cXZarMEDtKzEP98rX
@uda-lab-agent

Copy link
Copy Markdown
Contributor Author

Response to the codex review (commit a5bc50e):

  • P2 (homepage not in project.urls): fixed in 38701a4 — moved to [project.urls] so it is actually emitted as a Project-URL in package metadata.
  • P1 (CI ends after pytest, doesn't run the notebook/Phase-4 AGENTS.md handoff validations): left as-is deliberately. This issue's scope (and the driving task brief) explicitly asked for a fast, pytest-only CI with gudhi isolated to one matrix leg; the notebook execution and Phase-4 acceptance runner (including the conditioning stress gate) are comparatively slow and are the repo's local agent handoff checklist (AGENTS.md "Required Validation Before Handoff"), not a CI requirement stated in this issue. Promoting them into CI is a reasonable follow-up but is out of scope here — flagging it for a separate issue rather than expanding this PR.

@t-uda

t-uda commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@codex please review this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 38701a48c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@uda-lab-agent
uda-lab-agent merged commit 07bcfc7 into main Oct 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore .venv, add CI, fix stale ellphi-alpha paths

2 participants