Repository navigation
Ignore .venv, add CI, fix stale ellphi-alpha paths - #3
Conversation
- Add .venv/ to .gitignore so a local venv does not need .git/info/exclude tricks. - Add .github/workflows/ci.yml: Python 3.10-3.12 matrix running pytest, with gudhi installed only on the 3.12 leg so the GUDHI-dependent tests run there (they self-skip otherwise). Uses `pip install -e .` rather than Poetry: the Poetry "demo" group bundles gudhi together with jupyterlab/matplotlib/pandas, which would make a gudhi-only CI leg slow; pip install -e . plus a standalone `pip install gudhi` keeps that leg fast. Package management migration (uv) is out of scope (ellcech#2). - Fix stale ellphi-alpha directory/URL references left over from the repo rename to ellcech: AGENTS.md scope line, README's `cd ellphi-alpha` install step, and pyproject.toml homepage URL. The importable package name `ellphi_alpha` is unchanged. Closes #1 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4X65cXZarMEDtKzEP98rX
|
@codex please review this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5bc50ea4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A bare homepage key under [project] is not part of PEP 621 and is not emitted as a Project-URL in package metadata. Move it to [project.urls] so the corrected URL actually reaches package metadata consumers (PyPI, pip show, etc). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C4X65cXZarMEDtKzEP98rX
|
Response to the codex review (commit a5bc50e):
|
|
@codex please review this PR |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
.venv/to.gitignore(previously only hidden locally via.git/info/exclude)..github/workflows/ci.yml: Python 3.10/3.11/3.12 matrix runningpytest;gudhiis installed only on the 3.12 leg so the GUDHI-dependent tests run there (they self-skip without it pertests/test_phase4_baseline.py).ellphi-alpha/old-URL references left from the repo rename toellcech:AGENTS.mdscope line, README'scd ellphi-alphainstall step,pyproject.tomlhomepageURL. The importable package nameellphi_alpha(and thepyproject.tomlname = "ellphi-alpha"project name) is unchanged per the issue scope.CI installer choice
The repo uses Poetry, but its
demooptional group bundlesgudhitogether withjupyterlab/ipykernel/matplotlib/pandas/tqdm. Installing that whole group just to getgudhion one CI leg would be slow and install unrelated heavy packages. Per the issue's allowance, CI instead usespip install -e .(pulls the[project.dependencies]— numpy, scipy, ellphi) pluspip install pytest pytest-cov, and a standalonepip install gudhion the 3.12 leg only. Poetry/uv migration is out of scope here (tracked separately as ellcech#2).Validation
(run with
gudhi3.13.0 present in the local.venv, so GUDHI-dependent tests executed, not skipped)Closes #1
🤖 Generated with Claude Code
https://claude.ai/code/session_01C4X65cXZarMEDtKzEP98rX