Skip to content

docs: clarify minimax gradient differentiability - #6

Merged
uda-lab-agent merged 1 commit into
mainfrom
issue-4-gradient-docstring
Oct 3, 2026
Merged

uda-lab-agent merged 1 commit into
mainfrom
issue-4-gradient-docstring

Conversation

@uda-lab-agent

Copy link
Copy Markdown
Contributor

Closes #4

Summary:

  • Clarify that for alpha > 0, differentiability is characterized by a singleton dual optimal set rather than strictly positive multipliers.
  • Explain that zero multiplier indices contribute zero gradient blocks and preserve the alpha = 0 exception.
  • Documentation and related comment wording only; no behavior, tests, or public API changes.

Validation:

  • Worktree-local .venv created and package installed editable with pytest using uv because system python3 lacks ensurepip.
  • python -c "import ellphi_alpha; print(ellphi_alpha.__file__)" -> /workspaces/.hermes-worktrees/ec4-docstring/src/ellphi_alpha/__init__.py
  • pytest -q -> 176 passed, 2 skipped.

🤖 Generated with Claude Code

@t-uda

t-uda commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@codex please review this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T04:44:05.890138Z d60c069 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: d60c069f26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@uda-lab-agent
uda-lab-agent merged commit ebe63a4 into main Oct 3, 2026
3 checks passed
@uda-lab-agent
uda-lab-agent deleted the issue-4-gradient-docstring branch October 3, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compute_gradient docstring conflates zero multiplier with non-differentiability

2 participants