Repository navigation
docs: fold in review notes on rank erosion and the cloud setup guide (#1003) - #1004
Conversation
…1003) Update sentences that still described a finite erosion test as only proposed, correct two example docstrings, derive Repr for the erosion test results so that an outcome can be displayed, and state what sandbox_status = ready means in the cloud setup guide. No statement, proof or pin changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RfoZqCRSgoUin4otWc6fXL
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed-by: claude-opus read-only reviewer (session distinct from the implementer) Reviewed head: Compiled: one scratch file Verdict: pass — no substantive findings. Three non-substantive notes. Findings
Dispositions
Checks not performedI did not run Generated by Claude Code |
Closes #1003
Summary
Hygiene follow-up to the final-head reviews of PR #996 and PR #1002, whose non-substantive notes were not pushed onto the reviewed heads.
docs/math/rank-erosion.md: the future-extensions paragraph now says which targets of the extension proposal are supplied (finite criterion, executable F₂ representations, certified finite test) and which remain proposed; four long lines rewrapped.docs/README.md: the rank-erosion paragraph mentions the finite reduction and the certified F₂ test; attainment remains proposed.CHANGELOG.md: theF2GridRepentry no longer says "no erosion test is included", which the next entry contradicted.TDA/Persistence/F2GridErosionExamples.lean: docstring ofemptyGrid_zerocorrected; the module docstring says the same violation is reported with the other direction when the two modules are exchanged.TDA/Persistence/F2GridErosion.lean:ErosionFailureandErosionResultalso deriveRepr, so an outcome can be displayed with#eval.docs/claude-cloud-setup.md:sandbox_status = readymeansbwrapis onPATH, not that the Comparator's sandbox start-up probe passes; the initial valuenot-attemptedis listed.Branch lifecycle
Ordinary develop topic: based on develop
1b6c2d9d5906993aae4a7c33e87c010d1f1109dd, targetdevelop, squash merge. Target scope: documentation hygiene; release version undecided. Propagation: N/A.Public declarations added / changed
Added: the derived instances
Repr (F2GridRep.ErosionFailure n)andRepr (F2GridRep.ErosionResult n). No statement, definition body, proof or pin changes.Source ↔ Lean correspondence
N/A — no statement change.
Validation
Evaluated head
849fa1b3331a4a070bf91af1a3f94da4c90f9936, base1b6c2d9d5906993aae4a7c33e87c010d1f1109dd.scripts/check.sh(full gate) on this head: exit 0,CHECK OK;AXIOM AUDIT OK — 13593 declaration(s),PRIVATE AUDIT — 10503 private theorem root(s),COVERAGE OK — 10954 public theorems, all pinned, Comparator accepted (1m42s). The three counts equal the base's.#eval runErosion interval zero (1/4)and(1/2)in a scratch file now print the failure record andpass.git pushpre-push gate: passed.checkfor this head: success — https://github.com/uda-lab/tda-lib/actions/runs/44659726932/job/136034696818 ; the log reportsAXIOM AUDIT OK — 13593 declaration(s),PRIVATE AUDIT — 10503 private theorem root(s),COVERAGE OK — 10954 public theorems, all pinned,Lean default kernel accepts the solution,CHECK OK, the same counts as the local run.scripts/test-guards.sh, doc generation, the documentation site build beyond what hosted CI runs.Remaining sorry / custom-axiom footprint
none
Independent review evidence
849fa1b3331a4a070bf91af1a3f94da4c90f9936: pass — docs: fold in review notes on rank erosion and the cloud setup guide (#1003) #1004 (comment) . It records three non-substantive notes; none was acted on, so the reviewed head is the head evaluated above.🤖 Generated with Claude Code
https://claude.ai/code/session_01RfoZqCRSgoUin4otWc6fXL