Repository navigation
feat(mapper): identify the executed graph-PL incidence lists with graphPLReebData and the Reeb quotient (#1006) - #1008
Merged
Merged
Conversation
…phPLReebData and the Reeb quotient (#1006) Read the executed cell and edge lists of a valid HeightGraph as finite Reeb data over the computed levels, prove them isomorphic to graphPLReebData with laws for component cells, crossing cells and listed edges, and derive the comparison with the extracted path-component data and with the Reeb quotient of the graph-PL height through the existing comparisons. With no vertex the realization is empty. Fixtures keep two parallel edges apart and instantiate the quotient comparison for a four-cycle. Fold in three notes of the review of the first unit. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RfoZqCRSgoUin4otWc6fXL
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
Reviewed-by: claude-opus read-only reviewer (session distinct from the implementer) Reviewed head: Verdict: pass with non-substantive notes. No substantive finding. Evidence
Findings (all non-substantive)
Checked / not checked
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1006
Summary
Second and last unit of #923: the semantic bridge from the executed incidence lists of #1005 to the existing graph-PL Reeb data and the Reeb quotient.
TDA/Mapper/GraphPLIncidenceReebData.lean:HeightGraph.reebDatareads the executed cell and edge lists of a valid input asFiniteReebDataover the computed levels, without renumbering;reebDataIsois an isomorphism of finite data tographPLReebData (X.graph hX) X.realHeight X.criticalValues, with the lawsreebDataIso_hom_v_inl,reebDataIso_hom_v_inr,reebDataIso_hom_e;extractReebDataIso(throughgraphPLExtractIso) andreebQuotientIso(throughgraphPLReebQuotientIsoOfIso) follow;isEmpty_realizationis the case of no vertex.TDA/Mapper/GraphPLIncidenceReebDataExamples.lean: two parallel edges of the triangle are different elements of the edge type with equal endpoints, and the simple incidence graph forgets one; the crossing cell ofcrossingand its image in the actual graph; the quotient comparison for the four-cycle; the empty input.docs/math/mapper.md, the Mapper row ofdocs/api.md, theCHANGELOG.mdentry of this feature.label,LevelVertexnamed in the math notes, and the cost paragraph of the math notes (statement formsleftEnd/rightEnd, validation cost).Branch lifecycle
Ordinary develop topic: based on develop
ca0fec5a5efcd999820e508159897cb24032aecf, targetdevelop, squash merge. Target scope: Reeb computation under #923/#227; release version undecided. Propagation: N/A.Public declarations added / changed
Added in
TDA.Mapper.GraphPL.HeightGraph:reebData,reebData_left_coe,reebData_right_coe,reebData_left_eq_leftEnd,reebData_right_eq_rightEnd,reebDataIso,reebDataIso_hom_v_inl,reebDataIso_hom_v_inr,reebDataIso_hom_e,extractReebDataIso,reebQuotientIso,isEmpty_realization; and the fixtures ofGraphPLIncidenceReebDataExamples. Changed: the docstring ofHeightGraph.labeland one sentence of the module docstring ofTDA/Mapper/GraphPLIncidence.lean; no statement, definition body or proof of an existing declaration changes.All listed statements of #1006 are present as stated; no supporting public lemma beyond the contract was added.
Source ↔ Lean correspondence
Library-derived unit; no external source statement. The governing specification is #923 and the contract #1006, whose statements were checked before admission by an independent reviewer that constructed the data and proved every statement in its own scratch files.
extractReebDataIsowas added to the contract after that review; the final-head review below checked its direction and covering list.Validation
Evaluated head
d2b0d9b54752522c3f8cc903a933d27c53f3e8d8, baseca0fec5a5efcd999820e508159897cb24032aecf.scripts/check.sh(full gate) on this head: exit 0,CHECK OK;AXIOM AUDIT OK — 13713 declaration(s),PRIVATE AUDIT — 10536 private theorem root(s),COVERAGE OK — 11024 public theorems, all pinned, Comparator accepted (3m13s). Base: 13686 / 10521 / 11007.git pushpre-push gate: passed.checkfor this head: success — https://github.com/uda-lab/tda-lib/actions/runs/44667402667/job/136059936334 ; the log reportsAXIOM AUDIT OK — 13713 declaration(s),PRIVATE AUDIT — 10536 private theorem root(s),COVERAGE OK — 11024 public theorems, all pinned,Lean default kernel accepts the solution,CHECK OK, the same counts as the local run.scripts/test-guards.sh, doc generation.Remaining sorry / custom-axiom footprint
none
Independent review evidence
d2b0d9b54752522c3f8cc903a933d27c53f3e8d8: pass with non-substantive notes — feat(mapper): identify the executed graph-PL incidence lists with graphPLReebData and the Reeb quotient (#1006) #1008 (comment) . Its notes (N1: one sentence of the math notes reads as the inverse ofgraphPLExtractIsowhere the inverse ofreebDataIsois meant; N2: placement of the validation-cost sentence; N3, N4: optional) were not acted on, so the reviewed head is the head evaluated above; N1 and N2 are left for a documentation follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01RfoZqCRSgoUin4otWc6fXL