Default shared_project to project_id for Kubernetes kubeconfig lookup - #14
Merged
Conversation
Without an explicit shared_project the engine fell back to a UDX-internal GCP project, so external callers deploying k8s-* modules failed with PERMISSION_DENIED and no explanation. Default to the caller's own project_id and document the kubeconfig secret contract.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
There was a problem hiding this comment.
Pull request overview
This PR prevents external callers of the k8s-* modules from accidentally falling back to an internal GCP project during kubeconfig secret lookup by defaulting shared_project to the caller’s project_id, and documents the kubeconfig secret contract as part of a patch release.
Changes:
- Default
SHARED_PROJECTtoinputs.project_idwheninputs.shared_projectis unset, preventing unintended Secret Manager lookups in a fallback project. - Document the
k8s-config-<cluster>-<namespace>Secret Manager naming/IAM contract and when to setshared_project. - Bump the action version to
1.0.6and add a matchingCHANGELOG.mdentry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds Kubernetes kubeconfig secret contract docs and updates shared_project input description/default. |
| action.yml | Defaults SHARED_PROJECT to project_id when shared_project is not provided. |
| package.json | Bumps version to 1.0.6. |
| CHANGELOG.md | Adds v1.0.6 entry describing the behavioral default + documentation update. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
balexey88
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
k8s-*modules fetch the cluster kubeconfig from a Secret Manager secretk8s-config-<cluster>-<namespace>inshared_project. When a caller does not setshared_project, the action passes an empty value and the engine falls back to a UDX-internal GCP project. External callers therefore fail withPERMISSION_DENIEDon a project they have never heard of, and the README does not describe the secret contract.Fix
shared_projectnow defaults toproject_idin the action, so the engine fallback never triggers for external callers.shared_project.Compatibility
Only callers that use
k8s-*modules and rely on the implicit fallback are affected. The two current callers were checked:udx/www.wpcloud.ionow setsshared_projectexplicitly (c0d11023, green run 33255548656);udx/demo-rabbit-exampleuses no k8s modules.make test: 41 passed.