chore(release): publish - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@ui5-community/jsx-runtime@0.1.3
Patch Changes
#10
2e704f8Thanks @petermuessig! - Fix: auto-prefix-id no longer prefixes UI5-generated ids (closes #9).Controls like
sap.m.Menucreate internal helper controls (e.g. aMenuWrapper) whose ids are generated by UI5 (matchingManagedObjectMetadata.isGeneratedId). Previously, when JSX constructedsuch controls inside a view with
getAutoPrefixId() === true, thosegenerated ids were passed through
view.createId(), making the internalcontrol unresolvable at add-time and causing a
TypeError.The runtime now guards the
createId()call with!ManagedObjectMetadata.isGeneratedId(rawId)so only author-supplied(static) ids are prefixed. Generated ids pass through untouched. Closes #9.
#10
e9ffb68Thanks @petermuessig! - JSX view-construction errors are now logged viasap/base/Login additionto propagating. Previously, when
createContent()threw (sync or async),the error was only visible as a rejected Promise and, in the showcase, as
a text message rendered into the DOM. It was never written to the UI5 Log,
making it invisible to log-scraping tooling and
sap-ui-log-leveldebugging.installViewScopeBridgenow wraps thecreateContent()call with atry/catch (sync) and a
.catchon the returned Promise (async). On failureit calls
Log.errorwith the full error message, the stack trace, and thecomponent id
"ui5.community.jsx.runtime", then re-throws / re-rejects soexisting propagation behaviour is unchanged.
The showcase's
ExploreSampleview also addsLog.errorcalls in both itsdemo-view and docs-load catch handlers so the exact user-facing message
appears in the log as well.