Repository navigation
fix(test): remove two invalid string-aggregation-binding QUnit cases - #8
Merged
Merged
Conversation
The childless case (`<List items="{/rows}" />` with no template) threw at
construction because UI5's `bindAggregation` requires a template — the
"works without a child" assumption was wrong.
The multi-child case failed because UI5 does not accept an array as a
`bindAggregation` template.
Remove both. The two remaining tests (single child, named-model prefix)
give full regression coverage for the issue #6 fix.
petermuessig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The childless case (
<List items="{/rows}" />with no template) threw at construction because UI5'sbindAggregationrequires a template — the "works without a child" assumption was wrong.The multi-child case failed because UI5 does not accept an array as a
bindAggregationtemplate.Remove both. The two remaining tests (single child, named-model prefix) give full regression coverage for the issue #6 fix.