Repository navigation
Conversation
Collaborator
|
like it but give me a few days to check more thoroughly. there might be a race condition here and I want to double check a few things like security implications and exit status semantics. and to think if there's anything to enforce the limitations beyond comments in the code, such as for TLS, non-posix clients, or servers proxied through nginx. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first approach has been included. It uses: cancelAPI() call that has to be used in a signal handler or different thread.
Although it is a bit out of scope,thi spart has been very useful for us:
In case of Python clients, I had to force multithreading for SIGINT handling, and only a specific set of python UDA API calls that don't manage internally numpy. For some internal operations, python numpy and multithreading can give problems.
1- In swig interface file:
%feature("nothreadallow");
%feature("nothreadallow", "0") UdaClientReaderBase::fetchData;
%feature("nothreadallow", "0") UdaClientReaderBase::getVariableList;
%feature("nothreadallow", "0") UdaClientReaderBase::getPulses2;
%include "../../c/include/uda/idam/udaStructs.h"
%include .....
....
2- In swig Makefile:
swig -c++ -python -threads ....