Accept normalized CLA signature comments - #49
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
LGTM. The change is scoped to the CLA signature workflow gate, allowing comments containing the valid signature text to reach the action matcher while preserving the exact recheck command behavior. No concrete regression is evident in the reviewed diff.
|
🎉 PR #49 was merged—thank you, @glenn-jocher!
This focused update improves CLA signature handling by allowing formatted comments and trailing whitespace to reach the action’s normalized matcher, while preserving exact |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to recognize comments containing the normalized CLA signature text, allowing trailing whitespace or surrounding Markdown to reach the action matcher.
📊 Key Changes
.github/workflows/cla.ymlwith acontains(...)check.recheckcommand comparison exact.🎯 Purpose & Impact
recheckbehavior remains unchanged.