Repository navigation
GenerateConfusables no longer updates timestamps for unchanged data - #1566
Merged
Merged
Conversation
Member
|
would you mind fixing the "Genereate" type in the commit message? |
markusicu
changed the title
roozbehp
force-pushed
the
roozbehp-timestamps
branch
from
September 24, 2026 05:06
9dd84bb to
3b471c2
Compare
Contributor
Author
Done. |
Contributor
Author
|
@markusicu @eggrobin @josh-hadley I would appreciate a code review of this, as it's blocking my further confusables work. |
markusicu
reviewed
Oct 18, 2026
Contributor
Author
|
Thank you very much @markusicu. PTAL. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
markusicu
approved these changes
Oct 18, 2026
| try (PrintWriter out = | ||
| new DiffingPrintWriter(output().toFile(), reference().toFile()) | ||
| .skipCopyright() | ||
| .toPrintWriter()) { |
Member
There was a problem hiding this comment.
FYI: this is not necessary in this case -- Writer itself can write(String)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111