Repository navigation
Conversation
This reverts commit 1986ef4.
Contributor
|
We may be able to turn specific kinds of CodeQL feedback off. There's a lot of other issues that CodeQL can detect (and has already detected) that are useful. |
Member
Author
|
Alright, let’s give that a shot… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1582.
See #1601 (review). We very routinely use things that are marked deprecated because they are for Unicode-internal but ICU-external use.
This level of noise is neither good for my sanity nor for the codebase.