Repository navigation
fix: keep the request URL when redirecting to HTTPS - #107
Merged
Merged
Conversation
The redirect wrote the new scheme and host through r.URL, so the caller saw its own request rewritten. Copy the URL first.
Contributor
Author
|
Thanks for merging this. The redirect Location is built from a copy, so the caller's request URL stays on the original scheme and host. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An HTTPS redirect assigned
r.URLand then changed the scheme and host. The caller still holds that request, so a later check can treat the original HTTP request as HTTPS, or keep the rewritten host. The Location header is now built from a copy, and the caller's URL stays as it arrived.Test plan
go test -count=1 .passesTestSSLRedirectLeavesRequestURLandTestSSLForceHostLeavesRequestURLfail onurl := r.URLand pass with the copy