Skip to content

Fix initial load animation sequencing #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miexil merged 2 commits into from
Aug 31, 2026
Merged

Fix initial load animation sequencing #276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6ba2f
fix: fix initial load animation sequencing
edouardmisset Aug 28, 2026
23f56f0
fix: keep animation guard non-reactive
edouardmisset Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions addon/components/hyper-table-v2/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,20 @@ export default class HyperTableV2 extends Component<HyperTableV2Args> {
@tracked scrollableTable: boolean = false;
@tracked initialFetchColumnsDone: boolean = false;
@tracked initialLoadAnimationActive: boolean = false;
@tracked initialLoadAnimationPlayed: boolean = false;

private initialLoadAnimationPlayed: boolean = false;
private initialLoadAnimationTimeout?: number;

declare private hypertableInstanceID: string;

constructor(owner: unknown, args: HyperTableV2Args) {
super(owner, args);
args.handler.fetchColumnDefinitions();
this.activateInitialLoadAnimationIfNeeded();
args.handler.fetchColumns().then(() => {
this.initialFetchColumnsDone = true;
args.handler.fetchRows().finally(() => {
this.activateInitialLoadAnimationIfNeeded();
this.finalizeInitialLoadAnimation();
});
this.computeScrollableTable();
});
Expand Down Expand Up @@ -280,12 +281,19 @@ export default class HyperTableV2 extends Component<HyperTableV2Args> {
return;
}

if (this.args.handler.communicationError || this.args.handler.rows.length === 0) {
this.initialLoadAnimationPlayed = true;
this.initialLoadAnimationActive = true;
}

private finalizeInitialLoadAnimation(): void {
if (!this.initialLoadAnimationActive || !this.initialLoadAnimation) {
return;
}

this.initialLoadAnimationPlayed = true;
this.initialLoadAnimationActive = true;
if (this.args.handler.communicationError || this.args.handler.rows.length === 0) {
this.initialLoadAnimationActive = false;
return;
}

const rowsAnimationWindowMs = Math.max(this.args.handler.rows.length - 1, 0) * this.initialLoadAnimation.staggerMs;
const activeDurationMs =
Expand Down
Loading