initialLoadAnimation - sync animation replay listeners when config changes - #279
Merged
Conversation
Miexil
requested review from
JulienVannier66 and
OwenCoogan
and removed request for
a team
September 4, 2026 15:08
JulienVannier66
approved these changes
Sep 4, 2026
phndiaye
approved these changes
Sep 4, 2026
edouardmisset
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initialLoadAnimation is enabled dynamically with reset-rows in replayOn, the replay event listener was never registered because listeners were only set up once in the constructor.
Now listeners are dynamically synchronized whenever the animation config changes, ensuring replay events work regardless of when the feature is enabled.
Good PR checklist