Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修复
Windows Setup 的临时任务启动确认将
LastRunTime与调用方Get-Date比较,仅允许 1 秒偏差。在本机,任务已运行,但调度器返回的时间早约 4.5 秒,导致错误的 75 秒超时;失败清理又可能留下占用bin/agentdock-tray.exe的进程,使回滚失败并阻断后续安装。本 PR 改为记录每个唯一临时任务的运行时间基线,通过任务
Running状态或时间基线变化确认启动,避免跨时钟比较。退出码和等待完成检查继续保留。失败清理会先停止临时任务;对于等待模式,通过本次唯一的 stdout 诊断参数及精确宿主路径定位进程树,停止子进程并释放诊断文件句柄。成功的后台启动保持子进程存活。安装器回滚同时停止核心计划任务、generation 进程与 stable shim 进程,再恢复文件。
范围
仅修改:
scripts/install/launch-windows-process.ps1scripts/install/install.ps1scripts/test/test-windows-runtime-launch-diagnostics.ps1未修改 Core/Tray 发布二进制、认证方式或 Tunnel 配置。补丁基于
main的2ffed4ee8f0392f77bb6dd4a5de268de31ffa9d3,保留上游已有的 PowerShell UTF-8 修复。验证
git diff --checkGO111MODULE=off GOTOOLCHAIN=local go test ./scripts/test/install_windows_test.gotest-windows-runtime-launch-diagnostics.ps1,使用官方 v0.9.1 Core CLI 和 GUI shim,模拟 60 秒调度器时间偏差committed、核心 v0.9.1 健康检查及配置中的公网健康检查均通过main后,重新执行脚本契约测试和 Windows helper 回归测试实机 Setup 验证针对基于 v0.9.1 重打包的安装包;移植到最新
main后未重新构建该分支的完整发布载荷。未运行完整跨平台测试或隔离账户下的 Windows installer E2E 套件。审查重点
Closes #179.