Skip to content

refactor(embedding): 收口共享 HTTP 客户端 - #57

Merged
uvwt merged 1 commit into
mainfrom
refactor/shared-embedding-client-20260929
Sep 29, 2026
Merged

uvwt merged 1 commit into
mainfrom
refactor/shared-embedding-client-20260929

Conversation

@uvwt

@uvwt uvwt commented Sep 29, 2026

Copy link
Copy Markdown
Owner

改动

  • 新增具体 internal/embedding 客户端,集中 OpenAI-compatible Embedding HTTP request、Bearer header、32 MiB response limit、公共 data/embeddings 响应解析与结构化 StatusError
  • Recall 保留自己的 endpoint 规则:只有 URL path 为空时补 /v1/embeddings,显式自定义 path 原样使用
  • Workflow 保留自己的 endpoint 规则:非 /v1/embeddings 后缀继续自动追加
  • Recall 保留历史单 embedding 响应兼容;共享 parser 与 Workflow 不接受这一 Recall 专属形态
  • Recall 非 2xx 错误仍保留 HTTP <code>: <bounded body>;Workflow 仍只暴露 HTTP status,不泄露上游 body
  • 默认 model/timeout 下沉到共享包;Recall 保留同名兼容别名,Workflow 不再依赖 Recall 包
  • 删除 Recall / Workflow 重复的 HTTP transport 和 indexed-response parser
  • 不引入 interface、provider/backend abstraction,也不把 index/store/batch/cosine/reindex 策略下沉到共享层

验证

  • go test ./internal/embedding ./internal/recall ./internal/workflow ./internal/httpx ./internal/settings
  • go list -deps ./internal/workflow 确认不再依赖 internal/recall
  • make check
  • make ci(含 go test -race ./... 与最终 build)
  • git diff --check
  • Agy Claude Sonnet 4.6 基于 untracked 新包和完整实际 diff 做最终只读复审:Clean Approval,无高/中优先级问题

@uvwt
uvwt force-pushed the refactor/shared-embedding-client-20260929 branch from 9288e7a to 862d1eb Compare September 29, 2026 11:33
@uvwt
uvwt merged commit 6abaf2b into main Sep 29, 2026
2 checks passed
@uvwt
uvwt deleted the refactor/shared-embedding-client-20260929 branch September 29, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant