Repository navigation
fix(omni-graph): copy local grammars sub-crate and add .dockerignore in Dockerfile - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Docker builds for the
rust-appimage caused by missing local sub-crate grammars during multi-stage image creation.Root Cause
In
tools/omni-graph/Cargo.toml,tree-sitter-matlabis declared as a local sub-crate path dependency:The
Dockerfilecopied manifest files,src/, andtests/, but omittedgrammars/, causing cargo build inside the container to fail withunable to update /app/grammars/tree-sitter-matlab.Additionally, the absence of a
.dockerignorecaused Docker to attempt uploading the 13GB hosttarget/directory as build context.Changes
COPY grammars ./grammarsintools/omni-graph/Dockerfile.tools/omni-graph/.dockerignoreignoring hosttarget/,**/target/,ui/, and.env.docker compose build rust-app).