Repository navigation
Steam join: resolve lobby in-process, drop RestartAppIfNecessary in w… - #60
Merged
Merged
Conversation
…orker
Joining a Steam P2P lobby always spawned the separate worker process, which
must load steam_api64.dll and init Steam again. On some installs that throws
DllNotFoundException('steam_api64'), and when the DLL is found the worker's
SteamAPI.RestartAppIfNecessary can make Steam relaunch the game, after which
the real game fails "Steam init" until Steam is restarted.
- Resolve the lobby in the game process first (TryRunJoin ->
TryRunJoinInProcess), using the SteamAPI the game already initialized, like
the in-process P2P host. It runs on the existing background task, never
takes the pump lock or calls RunCallbacks off the main thread; the worker is
only a fallback when in-process Steam is unavailable.
- Remove RestartAppIfNecessary from the worker; set SteamAppId/SteamGameId.
- Preload steam_api64.dll by full path in PrepareSteamNativePath.
TenerexBlatta
force-pushed
the
steam-join-fix-0.5.1
branch
from
November 9, 2026 00:02
0f7fd6e to
8945264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orker
Joining a Steam P2P lobby always spawned the separate worker process, which must load steam_api64.dll and init Steam again. On some installs that throws DllNotFoundException('steam_api64'), and when the DLL is found the worker's SteamAPI.RestartAppIfNecessary can make Steam relaunch the game, after which the real game fails "Steam init" until Steam is restarted.
Pull Request
Summary
Describe what this pull request changes.
Type of change
Related issue
Fixes #
What was changed?
Testing
How did you test this?
Known issues
List any problems or unfinished parts.
Checklist