fix(transcript): keep a message's image chip in the body text flow - #1411
Merged
Merged
Conversation
An attachment the user message body does not already name inline was rendered as a block above the text, so a sent image read as a header instead of part of the message. The chip now continues the body line, while an image-only message still shows its own chip. The chips stay a list for assistive technology, and both the rendered-message contract and the transcript scenario cover the position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An attachment a user message does not already name inline was rendered as a block above the message text. It now continues the body line, so a sent image reads as part of the message instead of a header over it.
Why
After #1400 and #1401 the draft and the message both show images as chips, but the message chip still sat in its own flex row above the text (
margin-bottom: 7px,display: flex), which looked like a detached top block.Notes
role="list"inside the body text container for assistive technology; an image-only message still renders its chip on its own.Checks
tsc -p apps/desktop/tsconfig.json --noEmitnode --test apps/desktop/test/*.test.mjs— 3513 passed (newsession-reference-uicase asserts the chip follows the text inside the body container)biome lint,scripts/check-style-tokens.mjsnode scripts/e2e-transcript-render.mjs— oknode scripts/e2e-image-chat.mjs— oknode scripts/e2e-composer-paste.mjs— ok04-ux/08-component-spec.md,06-delivery/04-e2e-test-plan.md(+ zh-CN)Task candidate
a840a14dbon basemainb9ad05edf.