fix(reasoning): keep the measured duration in plain state - #499
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
useControllableState warns when the duration prop goes from undefined while streaming to a number once reasoning finishes. duration has no change callback, so the prop now takes precedence over the internal timer without the controlled/uncontrolled switch.
Contributor
|
@RaphaelFakhri is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496
ReasoningstoreddurationinuseControllableState. A caller that passesduration={undefined}while streaming and a number once reasoning finishes switches the hook from uncontrolled to controlled. React logs this warning in development for every finished reasoning block:durationhas no change callback, so the controllable-state hook adds nothing. This change keeps the measured duration inuseStateand usesdurationProp ?? measuredDuration. The displayed value is the same in both modes: the prop when it is defined, otherwise the internal timer.Tests
does not warn when duration is set after streaming endsrenders withduration={undefined}andisStreaming, then rerenders withduration={3}. It fails before the change and passes after.prefers the duration prop over the measured durationchecks that a prop value wins over the timer.Before the change: 2 failed, 18 passed. After: 20 passed. The full
packages/elementssuite passes (47 files, 960 tests).