Conversation
An accept entry like .xlsx never matched in matchesAccept, which only compares MIME types, so files allowed by the file dialog were dropped when added, pasted or dropped. Extension patterns are now matched against the file name, case-insensitive, as the HTML accept attribute does.
Contributor
|
@HardMax71 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matchesAcceptnow treats anacceptentry that starts with "." as a file extension and matches it against the file name, case-insensitive, as the native file input does. MIME patterns (image/*,application/pdf) work as before. I also updated theacceptdocs and prop comment and added a changeset.New test in
__tests__/prompt-input.test.tsx, "matches file extension patterns against the file name": withaccept=".xlsx, .csv", areport.xlsxwith an empty type and aDATA.CSVwithapplication/octet-streamare added andnotes.txtis rejected withcode: "accept". It fails on main and passes here. The full@repo/elementssuite passes (959 tests).Closes #501