Conversation
ChainOfThoughtHeader and ChainOfThoughtContent each rendered their own Collapsible root, so the trigger's aria-controls named the content id of the header's root, which never renders, and the content had an id no control referenced. ChainOfThought now renders the Collapsible root, as Reasoning does, and the header and content use its trigger and content.
Contributor
|
@HardMax71 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChainOfThoughtnow renders theCollapsibleroot, asReasoningdoes, andChainOfThoughtHeaderandChainOfThoughtContentrender only the trigger and the content inside it, so Radix setsaria-controlsand the content id itself. The context still carriesisOpenfor the chevron, and the content keeps the context check, so using it outsideChainOfThoughtthrows as before.One visible difference: the two wrapper divs are gone. With the content open the spacing is the same. With it closed, the empty content root used to be the last child of the
space-y-4container and gave the header a 1rem bottom margin; that margin is gone. I checked both states on a static page with the same markup and compiled Tailwind classes.New test in
__tests__/chain-of-thought.test.tsx, "points the header's aria-controls at the content": fails on main, passes here. The full@repo/elementssuite passes (959 tests).Closes #505