Repository navigation
Conversation
In the grid and inline variants the remove button was opacity-0 until group-hover. Tab focus landed on a button that stayed invisible, and Tailwind v4 wraps hover variants in @media (hover: hover), so on touch screens the button never appeared. It now also shows on focus-visible and on coarse pointers.
Contributor
|
@HardMax71 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
focus-visible:opacity-100andpointer-coarse:opacity-100next togroup-hover:opacity-100on the remove button in thegridandinlinevariants. With a mouse nothing changes. I also updated theAttachmentRemovedocs and added a changeset.The elements test setup does not load Tailwind CSS, so the new
__tests__/attachments.test.tsxonly checks that both classes are on the button in both variants; it fails on main and passes here. I checked that Tailwind 4.1.18 compilespointer-coarse:opacity-100to a rule inside@media (pointer: coarse)andgroup-hover:opacity-100to one inside@media (hover: hover). The full@repo/elementssuite passes (960 tests).I kept
QueueItemAction, which has the same pattern, out of this PR.Closes #507