Repository navigation
PLAT-9463: Fix the Python CI (Python 3.9 runner and schema command) - #57
Open
FelipeG2000 wants to merge 1 commit into
Open
FelipeG2000 wants to merge 1 commit into
FelipeG2000 wants to merge 1 commit into
Conversation
- Run the Test workflow on ubuntu-24.04: ubuntu-latest is now 26.04, which has no Python 3.9, and the failed job cancels the rest of the matrix. - Make `veryfi schema` read Typer's command and parameter objects by duck typing. Newer Typer ships its own copy of click, so `import click` and `param.type` no longer work, which broke test_cli and left coverage under the 75% gate. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Test workflow is red on every PR, for two reasons that have nothing to do with the code under review:
ubuntu-latestis now Ubuntu 26.04, which has no Python 3.9. The failed 3.9 job cancels the rest of the matrix, so tests never run. The workflow now runs onubuntu-24.04, which still has 3.9 to 3.13.veryfi schemausedimport clickandparam.type, so it crashed andtest_clifailed, which also left coverage under the 75% gate. It now reads Typer's command and parameter objects by duck typing, so it works with both old and new Typer.Tests
coverage run -m pytest tests,coverage report) on Python 3.11: 62 tests pass and coverage is 75.71%. Before,test_clifailed and coverage was 73.65%.typer==0.12.5andclickinstalled, so the change is backward compatible.black --checkis clean. I could not run the 3.9 job here, so it is only confirmed once this PR's checks run.🤖 Generated with Claude Code