Repository navigation
ci: install the pinned npm CLI with --ignore-scripts - #5485
Conversation
SonarQube rule S6505 flags the two publication jobs' global npm install for running lifecycle scripts, which drops main's new-code security rating to C and fails the quality gate on every push. The npm package needs no install scripts.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
|
Score: 93/100. Small CI hardening change that clears the SonarQube S6505 findings, with the test pin updated to match.
I did not run the tests locally. I reviewed the diff only. Generated by Claude Code |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|



Summary
Main's CI/CD run has failed the SonarQube Cloud quality gate on every push since 6 Nov: new-code Security Rating is C (required A). The two findings are rule S6505 on the publication jobs'
npm install --global "npm@${NPM_CLI_VERSION}"(cicd.ymllines 1667 and 1890). Both now pass--ignore-scripts; the npm package has no install scripts that the CLI needs.Tests
tests/integration/ci/registry-release-workflow.test.tspins the new step command and passes.