Red Brinstar Fireflea Room: low energy spark to block by dragonsinth · Pull Request #2972 · vg-json-data/sm-json-data

dragonsinth · 2026-09-09T02:07:13Z

https://discord.com/channels/1053421401354285129/1053436236628496454/1546988210985631864

Similar to #2963 - add a strat to allow 99 energy spark.

Copilot

🟢 Approval recommended

The changes are self-contained data additions with consistent schema usage (new strats without IDs, notable added with updated nextNotableId) and no detected structural issues.

Pull request overview

Adds a new “Low Energy Spark to Block” technique/strat option for Red Brinstar Fireflea Room, expanding the room’s shinespark routing logic to account for intentionally low-energy horizontal midair sparks.

Changes:

Added two new strats for reaching the block via a low-energy midair horizontal shinespark when entering shinecharged or shinecharging.
Added a corresponding notable (“Low Energy Spark to Block”) and advanced nextNotableId.

File summaries

File	Description
region/brinstar/red/Red Brinstar Fireflea Room.json	Adds new low-energy shinespark strats and a notable to document/enable the technique.

Review details

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

kjbranch

This needs a much more detailed description.

where to spark from
mention that being higher gives more wiggle room when falling

kjbranch · 2026-09-09T14:37:29Z

+        {"shineChargeFrames": 42},
+        "canHorizontalMidairShinespark",
+        {"resourceAtMost": [{"type": "RegularEnergy", "count": 99}]},
+        {"shinespark": {"frames": 70, "excessFrames": 4}}


I think with these excess frames, you would need to start in a different position, which is then canControllShinesparkEnd.

Suggested change

{"shinespark": {"frames": 70, "excessFrames": 4}}

{"shinespark": {"frames": 70, "excessFrames": 0}}

When I was testing this out, I was normalizing the start position to be close to the ceiling, and 2-3 tiles right of the end of the platform. So then from that start, with 95-99 hp I was close enough to the block to fall into it by holding left or right. So this line was me trying to reflect what I tested, but I'm not dogmatic about it, we could just say you need exactly 99.

Re-testing, at 95 you need a pretty big jump forward. So I think your inclination to just normalize at 99 is probably right. With 99 energy, the startup position is incredibly lenient, anywhere from directly over the last platform tile, up to 6 tiles out, works as long as you're close to the ceiling.

Basically there's a 7-tile window that works, because ending the spark anywhere from -3 to +3 allows you to fall onto to the block.

dragonsinth · 2026-09-09T15:17:48Z

This needs a much more detailed description.

where to spark from

mention that being higher gives more wiggle room when falling

True, in my head I was imagining that it's paired with a video; but I'll call this out in more detail.

dragonsinth · 2026-09-09T16:08:25Z

Updated the description, removed the excess frames.

dragonsinth · 2026-09-14T19:25:17Z

@osse101

blkerby · 2026-09-15T23:20:05Z

+      },
+      "requires": [
+        {"notable": "Low Energy Spark to Block"},
+        {"shineChargeFrames": 42},


Suggested change

{"shineChargeFrames": 42},

{"shineChargeFrames": 30},

How'd you get a number that low? @kjbranch told me I should come in with 0 momentum.

https://videos.maprando.com/video/10995 I measured 174 - 131 - 1 = 42

If it makes a difference, I had Spark Booster no Blue.

You can spark from closer to the door. Updated the suggestion to 30 frames after messing with it a bit more. The randomizer has leniency on shinecharge frames so it won't end up being expected to be done this tight except on the highest difficulties.

https://videos.maprando.com/video/11003

Okay true. I was shooting my video to show the optimal positioning more than the minimum frames. So you'd only have to get it that tight on insane; on "normal" settings the shinespark leniency will be fine.

Updated all comeInShinecharging strats from 1 to be 5, 0, and all the ones from 2 to be 4, 0.

FWIW, I didn't realize openEnd: 1 on the end of the charge meant falling off the block, I assumed it just meant you had like half a block more because there wasn't an immediate wall.

blkerby · 2026-09-15T23:21:23Z

The strats should end at node 3 rather than node 2.
I would remove the part of the note about using the Waver for i-frames, as there are several possible options to progress from node 3 to node 2 which are covered in other strats.
The comeInShinecharging should have length: 5 (door shell isn't included on entry since Samus spawns past it) and openEnd: 0 (since we don't want to include sliding off the runway). It looks like this was an error in the existing 1->2 strat (id: 10), which could also use a correction if you don't mind.

dragonsinth · 2026-09-16T02:02:17Z

The strats should end at node 3 rather than node 2.

Whoops, fixed.

I would remove the part of the note about using the Waver for i-frames, as there are several possible options to progress from node 3 to node 2 which are covered in other strats.

Done.

The comeInShinecharging should have length: 5 (door shell isn't included on entry since Samus spawns past it) and openEnd: 0 (since we don't want to include sliding off the runway). It looks like this was an error in the existing 1->2 strat (id: 10), which could also use a correction if you don't mind.

Fixed, but I should note that in this room, all of the comeInShinecharging strats from node 2 are inconsitent with each other. It looks like they should all be length 4, openEnd 0? Although-- I don't know enough about spikesuit / x-mode to know, maybe the intent is to fall onto the spikes.

blkerby · 2026-09-17T02:32:25Z

Fixed, but I should note that in this room, all of the comeInShinecharging strats from node 2 are inconsitent with each other. It looks like they should all be length 4, openEnd 0?

Right, I think the node 2 ones should all be length 4, openEnd 0. At best, sliding off would make you take an extra spike hit which isn't modeled.

The way it works in general:

for a spikesuit you could slide off as long as you can be fully morphed before you reach the spikes. At node 2, I doubt there would be enough vertical space to make that work (though I haven't tested it), and even if somehow possible it would be need higher tech requirements, so making it openEnd: 0 should be right either way. At node 1, I think you could slide off into a spikesuit with no problem since there's lots of space.
for an X-mode blue suit, you need to bounce before the X-mode, so sliding off would mean the bounce happens on the spikes, meaning you would need to take an extra spike hit. I would probably just shorten the runways to make them openEnd: 0 rather than trying to add an alternative with an extra spike hit.

But yeah, looks like node 1 also has other strats done inconsistently. We could probably use another pass through the whole game's logic to see if there are more inconsistencies like this (there probably are).

Red Brinstar Fireflea Room: low energy spark to block

902f802

Copilot AI lite review requested due to automatic review settings September 9, 2026 02:07

Copilot started reviewing on behalf of dragonsinth September 9, 2026 02:07 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

kjbranch reviewed Sep 9, 2026

View reviewed changes

dragonsinth added 2 commits September 9, 2026 11:58

feedback

bb6993e

shortly

eb322e6

blkerby reviewed Sep 15, 2026

View reviewed changes

feedback

de45183

30 frames, fix runways

527d860

	{"shinespark": {"frames": 70, "excessFrames": 4}}
	{"shinespark": {"frames": 70, "excessFrames": 0}}

Conversation

dragonsinth commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

kjbranch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dragonsinth Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dragonsinth commented Sep 9, 2026

Uh oh!

dragonsinth commented Sep 9, 2026

Uh oh!

dragonsinth commented Sep 14, 2026

Uh oh!

blkerby Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blkerby commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dragonsinth commented Sep 16, 2026

Uh oh!

blkerby commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dragonsinth commented Sep 9, 2026 •

edited

Loading

dragonsinth Sep 9, 2026 •

edited

Loading

blkerby Sep 15, 2026 •

edited

Loading

blkerby commented Sep 15, 2026 •

edited

Loading