Automated Protos Update: Python wrappers - #1261
Conversation
8ccae9f to
3edbb01
Compare
3edbb01 to
c24b60e
Compare
|
Claude (@claude) instead of creating a new dataclass for arm properties, please just typealias the arm proto's |
|
Claude finished Naveed Jooma (@njooma)'s task in 2m 53s —— View job Implementing type alias for arm properties
Done. Here's what changed:
All tests assertions remain valid since |
|
Claude (@claude) type it properly with the typealias type-hint |
|
Claude finished Naveed Jooma (@njooma)'s task in 1m 18s —— View job Adding
|
|
Claude (@claude) fix the test errors -- seems like you missed adding the new abstract methods to the |
|
Claude finished Naveed Jooma (@njooma)'s task in 1m 38s —— View job Fixing test errors in
|
|
Claude (@claude) also update |
|
Claude finished Naveed Jooma (@njooma)'s task in 3m 51s —— View job Updating additional example files
Done. All three files now implement the three new abstract methods:
|
Replace the custom `Arm.Properties` dataclass with a type alias pointing to the proto's `GetPropertiesResponse`. This eliminates the manual conversion in client.py and the `**__dict__` splat in service.py. Co-authored-by: Naveed Jooma <njooma@users.noreply.github.com>
Co-authored-by: Naveed Jooma <njooma@users.noreply.github.com>
set_manual_mode, get_manual_mode, and get_properties were added as new abstract methods to Arm but not implemented in the FakeArmClient used by test_robot.py, causing instantiation errors. Co-authored-by: Naveed Jooma <njooma@users.noreply.github.com>
…mplementations Co-authored-by: Naveed Jooma <njooma@users.noreply.github.com>
598e33b to
5026bab
Compare
This is an auto-generated PR updating the Python wrappers for the proto changes in #1260.
This PR is stacked on top of
workflow/update-proto. Review and merge #1260 first; this PR will retarget tomainautomatically.