Skip to content

Docs/security benchmark python315rc1 - #383

Merged
vinitkumar merged 5 commits into
masterfrom
docs/security-benchmark-python315rc1
Aug 12, 2026
Merged

Docs/security benchmark python315rc1#383
vinitkumar merged 5 commits into
masterfrom
docs/security-benchmark-python315rc1

Conversation

@vinitkumar

@vinitkumar vinitkumar commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

Document new security hardening benchmark results comparing pre-hardening and hardened Json2xml public API performance across CPython 3.14.6 and 3.15.0rc1, and integrate a high-level summary into the architecture benchmarks overview.

Documentation:

  • Add detailed Security Hardening benchmark section to BENCHMARKS.md, including methodology, CPython 3.14.6 and 3.15.0rc1 results, output checks, and interpretation of performance tradeoffs.
  • Extend architecture benchmarks documentation with a concise summary of the August 2026 public-wrapper benchmark and its validated performance/regression patterns.

@sourcery-ai

sourcery-ai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adds a new August 2026 security hardening benchmark section and ties its results into the architecture docs, documenting performance tradeoffs of Json2xml security changes (conversion limits, lexical pretty printing, compact default output) across CPython versions and interpreters.

File-Level Changes

Change Details Files
Document the August 2026 security hardening benchmark for Json2xml and its performance tradeoffs.
  • Added a dedicated "Security Hardening Benchmark" section describing methodology, environment, and workloads.
  • Recorded detailed CPython 3.14.6 and CPython 3.15.0rc1 timing tables for default, compact, and pretty modes with before/after comparisons.
  • Documented uv tooling steps and provenance checks for installing and verifying CPython 3.15.0rc1.
  • Added output-type and size comparison table showing default/pretty contract changes and compact byte stability.
  • Summarized interpretation of performance changes, isolating the compact-mode regression to the new resource-budget scan and confirming behavior on PyPy.
BENCHMARKS.md
Integrate the new public-wrapper benchmark results into the architecture benchmark overview.
  • Referenced the August 2026 public-wrapper benchmark and the specific pre-hardening and hardened commits it compares.
  • Summarized percent improvements/regressions for default, pretty, and compact modes on CPython 3.14 and CPython 3.15.0rc1.
  • Noted that the detailed record includes interquartile ranges, uv and interpreter provenance, and output consistency checks for compact bytes.
lat.md/architecture.md
Begin wiring the new benchmark documentation into the Sphinx/docs benchmarks page.
  • Updated or created the reStructuredText benchmarks document to reflect the presence of the new security hardening benchmarks (content not shown in diff snippet).
docs/benchmarks.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The mention of “macOS 26.6.1” in the security hardening benchmark section looks like a typo or future-dated version; please correct this to the actual macOS version used to avoid confusion about reproducibility.
  • In lat.md/architecture.md, consider adding an explicit cross-reference (anchor or section name) to the new “Security Hardening Benchmark (August 12, 2026)” section in BENCHMARKS.md so readers can easily jump to the detailed methodology and results.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The mention of “macOS 26.6.1” in the security hardening benchmark section looks like a typo or future-dated version; please correct this to the actual macOS version used to avoid confusion about reproducibility.
- In `lat.md/architecture.md`, consider adding an explicit cross-reference (anchor or section name) to the new “Security Hardening Benchmark (August 12, 2026)” section in `BENCHMARKS.md` so readers can easily jump to the detailed methodology and results.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (48dfd38) to head (93e61ee).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1037      1037           
=========================================
  Hits          1037      1037           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae5f9fd331

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread BENCHMARKS.md Outdated

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

Comment thread benchmark_security_hardening.py Outdated
@vinitkumar
vinitkumar merged commit 917bc65 into master Aug 12, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant