Repository navigation
chore(deps): drop @types/splitpanes - #630
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the removal of @types/splitpanes and its Vue 2 dependency chain.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Removes @types/splitpanes from the Vite and Rolldown analyzer packages and shared dependency configuration, also eliminating its Vue 2 dependency chain.
Changes:
- Removes the type package from both package manifests and the workspace catalog.
- Updates the lockfile, pruning Vue 2 entries and refreshing transitive DevTools dependencies.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Removes the @types/splitpanes catalog entry. |
pnpm-lock.yaml |
Removes obsolete type and Vue 2 entries; refreshes dependency resolutions. |
packages/vite/package.json |
Drops the analyzer’s @types/splitpanes dev dependency. |
packages/rolldown/package.json |
Drops the analyzer’s @types/splitpanes dev dependency. |
Review effort: Balanced
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
`@types/splitpanes` depends on vue 2, which carries an unpatched ReDoS advisory. splitpanes 4 ships its own types, so the package is redundant.
webfansplz
force-pushed
the
fix/drop-types-splitpanes
branch
from
November 4, 2026 08:18
f1c3176 to
cd55902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
@types/splitpanesfrom@vitejs/devtools-rolldownand@vitejs/devtools-vite(and the catalog). This removesvue@2.7.16from the dependency tree, which resolves Dependabot alert 18 (vue 2 ReDoS, no patched 2.x release).