Repository navigation
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A chunk can grow while its members keep the same transform sizes. Following that chunk into Modules currently produces an empty list, and searching cannot reveal its unchanged members. The header also combines a graph-wide module count with sizes summed only from output-chunk members.
Add All and Unchanged views with the existing path/package search and both-side chunk filter. Label the metric Transformed Code Size, count compared members, and explain membership and session-wide totals. The existing change modes and 300-row limit stay available.
Follow-up to #615 and #601. This PR targets main independently of #631, which handles missing and zero measurements. Both touch the comparison view and need integration when the first merges.
Evidence
pnpm lint,pnpm typecheckandpnpm buildpassed (7 build tasks).pnpm test --run: 408 passed, 2 skipped. New tests cover unchanged-member search, both-side chunk filtering and member counts.Merge Danger
Door: two-way
Blast Radius: modules
This changes module-list access and labels. It preserves module matching and the transform-stage measurement. It does not attribute final emitted bytes to individual modules.