Skip to content

feat(rolldown): expose unchanged comparison members and metric scope - #632

Draft
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:feat/compare-module-context
Draft

SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:feat/compare-module-context

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

A chunk can grow while its members keep the same transform sizes. Following that chunk into Modules currently produces an empty list, and searching cannot reveal its unchanged members. The header also combines a graph-wide module count with sizes summed only from output-chunk members.

Add All and Unchanged views with the existing path/package search and both-side chunk filter. Label the metric Transformed Code Size, count compared members, and explain membership and session-wide totals. The existing change modes and 300-row limit stay available.

changed chunk → Modules → All / Unchanged → A/B module details

Follow-up to #615 and #601. This PR targets main independently of #631, which handles missing and zero measurements. Both touch the comparison view and need integration when the first merges.

Evidence

  • Before: unchanged members are removed before search, and the header counts the entire graph.
  • After: unchanged members remain searchable from either chunk side; each header counts only that session's compared members.
  • pnpm lint, pnpm typecheck and pnpm build passed (7 build tasks).
  • pnpm test --run: 408 passed, 2 skipped. New tests cover unchanged-member search, both-side chunk filtering and member counts.
  • Executed Vue setup controls select All for an unchanged-only comparison and report 3 compared members when the graph has 99. Full browser acceptance was not rerun.

Merge Danger

Door: two-way

Blast Radius: modules

This changes module-list access and labels. It preserves module matching and the transform-stage measurement. It does not attribute final emitted bytes to individual modules.

@pkg-pr-new

pkg-pr-new Bot commented Nov 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@632

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@632

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@632

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@632

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@632

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@632

commit: e61d093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant