Repository navigation
fix(ai): 🐛 Make the chat temperature optional for providers that reject it - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Haiku 5.5 rejects every
temperaturevalue ("temperatureis deprecated for this model"), so Quire could not use it: each insight request would fail with a 400.QUIRE_SERVER_AI_TEMPERATUREnow sets the value. It defaults to0.2, so existing deployments send exactly what they sent before. An empty value ornoneleaves the parameter out of the request.Nothing else changes for Haiku. Anthropic's OpenAI-compatible endpoint accepts
json_schemamode but ignores it, and the client already detects that and moves the schema into the prompt (#102).Unit tests cover the setting parsing, the client body and the wiring.