Repository navigation
Sync highlights through Quire Server - #166
Merged
Merged
Conversation
vitofico
marked this pull request as ready for review
October 30, 2026 18:20
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds highlight sync through the configured Quire Server account. The existing manual, library-resume and reader-pause sync paths now exchange quotations, exact locators, colours, book snapshots and deletion tombstones; local edits also enqueue sync. Highlights remain independent of downloaded files.
Account-scoped storage and frozen request credentials keep one account's passages out of another account's requests. Existing unowned highlights join the first successfully authenticated highlight account. OPDS-only passages remain local to their catalog/account. Pending edits survive unavailable or older servers, interrupted requests and concurrent local changes.
Server push/pull endpoints use deterministic conflicts and per-user revision cursors protected against late commits. Shared Python/Kotlin wire fixtures check Unicode text, opaque locator preservation and conflict ordering. Identity-hash versions never decrease.
Storage and compatibility
progress_004adds user-scoped highlights and revision state for full/sync-only deployments; account export/purge includes them.Validation
e4d5749: Android debug/release builds, all unit tests, lint, 26 browser regressions, license drift and repository/release-tooling guards; server tests in full/sync-only/AI-only modes; Java/Kotlin and Python CodeQL.Related issues
Refs #143. PR 3 follows #164 and #165.