Repository navigation
✨ feat(reader): add memory bookmarks and stopping guidance - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add deliberate Pause & resume bookmarks with an optional note, saved passage and explicit return/edit/replace/remove actions. The sheet also shows a coarse whole-book distance to the next mapped stopping point, with unavailable states when positions cannot support an estimate.
Bookmarks remain device-local and account/catalog scoped. Room migration preserves existing progress. Reader restoration now captures the original DOM point before preference changes, verifies actual resource/font/paragraph visibility, bounds callback waits and rejects adjacent-resource captures. Configuration recreation preserves navigation and drafts.
Integration status
Integrated current main while preserving persisted, browsable and account-scoped synced highlights, quote copying and device-local memory bookmarks. Pause & resume is in More beside Highlights and Book details, avoiding extra toolbar crowding. Shipped Room schemas and migrations 10/11 remain canonical; schema 12 adds memory bookmarks and tests preserve highlight text, locations, ownership, tombstones, sync stamps and progress across shipped upgrades.
Highlight transactions and bookmark/slider navigation retain independent progress guards and safe rollback. Both use a shared resource-specific JavaScript bridge with cancellation-aware 1500 ms callback bounds, so a missing callback cannot indefinitely block a new navigation. The latest upstream read-only highlight API is retained unchanged.
Component(s)
Validation
Screenshot
Original synthetic fixture at 320 dp and 1.8 system font scale, scrolled to the saved-passage actions.
Checklist
core/identity: unchanged