Skip to content

fix(create): align package manager versions and pnpm workspace config - #3197

Open
evan-lc wants to merge 7 commits into
voidzero-dev:mainfrom
evan-lc:fix/library_template
Open

evan-lc wants to merge 7 commits into
voidzero-dev:mainfrom
evan-lc:fix/library_template

Conversation

@evan-lc

@evan-lc evan-lc commented Oct 22, 2026 •

Copy link
Copy Markdown

vp create could generate settings and report a package manager version that differed from the version selected by VP_PACKAGE_MANAGER. The command now uses the resolved override for configuration, installation, and its summary. The local CLI also honors the override during installation.

Standalone pnpm projects now declare the root package in pnpm-workspace.yaml when the file has no packages field. This allows older pnpm versions to install projects that use catalogs or workspace settings. Existing workspace patterns remain unchanged.

Standalone pnpm workspace configuration Original vp create installation failure

@fengmk2

fengmk2 commented Oct 23, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T03:48:45.537929Z af8c2c4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bea737231

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Snapshot the complete generated workspace file and update all standalone pnpm migration expectations.
@evan-lc

evan-lc commented Oct 26, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2

fengmk2 commented Nov 10, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: af8c2c42bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2 fengmk2 self-assigned this Nov 10, 2026
@fengmk2

fengmk2 commented Nov 10, 2026

Copy link
Copy Markdown
Member

Thanks for the fix! I’ll take over this PR and make a few adjustments before merging.

@fengmk2 fengmk2 changed the title fix(create): include root in standalone pnpm workspace fix(create): align package manager versions and pnpm workspace config Nov 10, 2026
@fengmk2 fengmk2 added the test: create-e2e Run `vp create` e2e tests label Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants