Repository navigation
ci: remove unused download-previous-rolldown-binaries job - #3403
Open
jong-kyung wants to merge 1 commit into
Open
jong-kyung wants to merge 1 commit into
jong-kyung wants to merge 1 commit into
Conversation
The job uploaded an npm-latest Linux rolldown binding that every consumer replaced immediately: build-upstream always reruns download-rolldown-binaries and copies the pinned host binding into the same directory. Because the job was missing from done.needs, a failure in it skipped all E2E and snapshot jobs while the required done check still passed. build-cli-test-binaries and cli-e2e-test-musl now gate on detect-changes directly so docs-only changes still skip them.
Collaborator
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
marked this pull request as ready for review
November 10, 2026 01:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download-previous-rolldown-binarieswas missing fromdone.needs. If it failed, all E2E and snapshot jobs were skipped and the requireddonecheck still passed.The job is also unnecessary. Every consumer runs
build-upstreamright after downloading its artifact,and
build-upstreamdownloads the pinned host binding again into the same directory. So the artifact was either overwritten on Linux or never loaded on macOS and Windows.