Skip to content

fix(completion): handle -C and vpr directory completion - #3410

Draft
nekomoyi wants to merge 3 commits into
voidzero-dev:mainfrom
nekomoyi:fix/completion-chdir-rust
Draft

nekomoyi wants to merge 3 commits into
voidzero-dev:mainfrom
nekomoyi:fix/completion-chdir-rust

Conversation

@nekomoyi

Copy link
Copy Markdown
Collaborator

Fix shell completion for -C and vpr:

  • Handle -- in completion arguments so -C <dir>, -C<dir>, and -C=<dir> correctly switch the target working directory for task suggestions instead of falling back to the current directory.
  • Fix Bash translating vpr -C forms to invalid syntax vp run -C ... instead of vp -C ... run, preserving task completion across separate, attached, and equals styles.
  • Fix Bash wordbreak handling by reassembling words split on = (e.g. -C=<dir>), and add directory ValueHint to -C.

@nekomoyi

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T05:12:46.112567Z 158dc7c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 158dc7c8b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nekomoyi
nekomoyi force-pushed the fix/completion-chdir-rust branch from 81e4f68 to d48f83d Compare November 10, 2026 05:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant