Repository navigation
Conversation
Since vite-task cb1ea8d (#3418), folder listings no longer skip `dist` entries (voidzero-dev/vite-task#919). In the monorepo template, `vp check`, `vp test`, and `tsc` list `packages/utils/` and `apps/website/` before `vp pack` and `vp build` create `dist/` there, so the second `vp run ready` misses under every package manager and `vp create monorepo (pnpm)` and `(bun)` fail on every run. npm and yarn already ran one extra warm-up for the `packages/utils/node_modules/` miss (#1638), so they reached 100% on the third run. Give pnpm and bun the same warm-up and describe both causes in the step's comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fengmk2
approved these changes
Nov 10, 2026
fengmk2
added
test: e2e
Member
Author
Merge activity
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp create monorepo (pnpm)andvp create monorepo (bun)have failed on every run since #3418 bumped vite-task to cb1ea8d. The "Verify cache (monorepo only)" step expects 100% cache hits on the secondvp run readybut gets 40%:vite-task no longer skips
distentries in folder listings (voidzero-dev/vite-task#919).readyrunsvp check && vp run -r test && vp run -r build, sovp check,vp test, andtsclist these folders beforevp packandvp buildcreatedist/there. The second run then sees the new entry and misses. The third run hits.npm and yarn already got one extra warm-up for the
packages/utils/node_modules/miss (#1638), so they kept passing. This PR gives pnpm and bun the same warm-up and rewrites the step's comment to describe both causes.#3418 didn't catch this because these jobs only run when create, template, or workflow files change.
Not included
This only fixes CI. A freshly created monorepo still needs three
vp run readyruns to be fully cached. Fixing that is a separate change:vp check,vp lint,vp fmt: oxlint and oxfmt skip gitignored folders, so the built-in cache config could add folder-entry exclusions for gitignored entries (!**/dist,!**/node_modules).!**/dist/**would be wrong: type-aware checks read other packages'dist/*.d.ts.vp test: Vitest 5 doesn't read.gitignoreand its defaultexcludedoesn't coverdist, so it does searchdistfor test files.tscin the website'sbuildscript: a third-party command, so only per-package config can excludedist.Test plan
vp create monorepopasses for pnpm, npm, yarn, and bun🤖 Generated with Claude Code