Repository navigation
feat(run): print the run plan as JSON with vp run --dry-run --json - #966
Conversation
fspy benchmarklinuxmacoswindows |
bbaeeed to
46fb5a3
Compare
46fb5a3 to
0143b35
Compare
0143b35 to
53cf064
Compare
53cf064 to
d1fa38a
Compare
d1fa38a to
be27709
Compare
be27709 to
60f53b9
Compare
60f53b9 to
526f134
Compare
| pretty: bool, | ||
| ) -> io::Result<()> { | ||
| let json = | ||
| if pretty { serde_json::to_vec_pretty(document) } else { serde_json::to_vec(document) }; |
There was a problem hiding this comment.
Why not directly write into a bufwriter?
There was a problem hiding this comment.
To keep stdout empty when serializing fails. A BufWriter writes out what it holds whenever its buffer fills, and again when it's dropped. So an error partway through, such as a workspace root that isn't valid UTF-8 (workspaceRoot serializes through Path, which rejects that), would leave half a document on stdout. Serializing into a Vec first means stdout is either the whole document or nothing. It's held in memory once more, but the document is small. The doc comment now gives this reason (744608b).
🤖 Generated with Claude Code
| **Exit code:** 2 | ||
|
|
||
| ``` | ||
| error: the argument '--json' cannot be used with one or more of the other specified arguments |
There was a problem hiding this comment.
This error message is confusing. We should mention that --json is only supported with --dry-run right now.
There was a problem hiding this comment.
Changed in 744608b. vp run --json build now says:
error: with a task, '--json' is only supported with '--dry-run' for now
vp run --dry-run --json without a task used to get the same conflict message, although the two flags go together. It now fails like vp run --dry-run does: No task specifier provided for 'run' command. vp run --json -r keeps clap's message, which is accurate there because the task graph takes no other argument. errors.md now covers all three, plus --json --last-details.
🤖 Generated with Claude Code
526f134 to
744608b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 744608b. Configure here.
Coding agents and CI need a dry run's answer as data, without parsing text: which tasks would run, in what order, and why each would hit or miss (#791, vite-plus#2848). `vp run --dry-run --json` prints the RFC's run plan through a new reporter. A task whose command runs `vp run` fails and says so for now. - CLI: `--json` is no longer `exclusive`. It conflicts with an explicit `--log`, and `RunCommand::resolve` checks the rest once, with clap-style errors: `--json` alone resolves to the task graph, and with `--dry-run` to a run whose `RunMode` is `DryJson`. With a task but no `--dry-run`, the error says `--json` is only supported with `--dry-run` for now; with other flags and no task, it's the same conflict error as before. Without a task, `--dry-run --json` fails when it's planned, as `--dry-run` does. The session matches on that, so no later code re-checks `--json`, and `plan_from_cli_run` resolves its command the same way. It's never interactive: a task that isn't found is an error on stderr, not the task list on stdout. An empty plan (`--filter` matched nothing) prints `"plan": {}`. - Cache data: `Comparison` gains the baseline's duration and `changes_partial`, set when the file check stopped at the first changed file or couldn't check some files. After a command, config or env change, only the previous run's key is compared, so the step is `changed` with no `baseline` and with `changesPartial`. Program, args and cwd changes keep what they changed from and to; vt_plan gets a program accessor on the spawn fingerprint and name/args accessors on built-ins. - Reporter (`session/reporter/json/`): when it's created, from the graph, it lays out each task's ID, sorted `dependsOn` and steps (`program`, `args`, `cwd`, `hook`). Each leaf's `start` fills in its `cache` (`hit`, `changed`, `noBaseline`, `error`, `disabled`, or absent for a built-in). At the end, it serializes the whole document and writes it once: indented in a terminal, on one line otherwise. A run cancelled by Ctrl-C prints nothing. A failed cache lookup stops the run, as it stops a real run: as for any error that stops the document, the error goes to stderr and nothing is printed. - Document: Rust types with doc comments, deriving schemars under `cfg(test)`; a test regenerates the committed `schemas/run-plan.json`, which `artifact!` embeds and each run copies to the user's temp folder for `$schema`, as for `vp run --json`. Both documents are written by one `json::write_document`, which serializes into memory first, so an error partway prints nothing. - Tests: the e2e fixture `run_plan_json` covers the plan's layout: `-r` edges and `--parallel`, hooks, programs inside and outside the workspace, `--no-cache` and `--cache`, forwarded args, the shell, `cd` and the `cwd` setting, built-ins, and encoded task IDs. Its `selection` case covers a task that some or all selected packages lack, an unknown package, and a filter that matches nothing, with and without `--fail-if-no-match`. `dry_run_json` covers the cache statuses, flags that combine with `--dry-run --json` and the same flags after the task name, and the errors: `--json` with a task but no `--dry-run`, with `--log`, with `--last-details`, or with flags but no task, `--dry-run --json` without a task, and a task that isn't found. In the plan snapshots, only the `--json build` error message changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
744608b to
220dbb0
Compare
## Motivation Before starting a long run, there's no way to see which tasks would come from the cache and which would run, or why one would miss, without running them (#791, voidzero-dev/vite-plus#2848). [The dry-run RFC](https://github.com/voidzero-dev/vite-task/blob/main/docs/rfcs/dry-run.md) specifies `vp run --dry-run` for this. This is the first PR of the stack that implements it: the text output. The PRs above it add every change of a miss (#961), `-v` (#963), `--json` (#966, #967), `unknown` (#968) and `-vv` (#969). This supersedes #792 by @lifeiscontent, whose write-free lookup and test scenario it builds on, so it credits them as co-author. Closes #791. ## Changes `vp run --dry-run` plans the run and checks the cache as a real run does, the remote cache included, then prints each command's line and the summary. It runs nothing and records nothing. The cache is opened as in a real run, but no entry is written, a hit's outputs aren't downloaded or restored, and `last-summary.json` isn't written, so `--last-details` still shows the last real run. ``` $ vp run --dry-run test $ vtt print-file src/a.txt ◉ cache hit $ vtt print tested --- vp run: 1/2 cache hit (50%), nothing was run. ``` - A dry run goes through the real run's lookup and spawn path, which skips each step that would write or run: recording a local hit, downloading a remote hit, replaying a hit, and spawning the command. - Each line is a real run's, without `, executing` or `, replaying`, and with no blank line between commands. `--log` is ignored, since it only shapes task output: `--dry-run` and `--log` move from `RunFlags`, which selects tasks, to `RunCommand`, and resolve to a `RunMode` of `Real { log }` or `Dry`, so a dry run can't carry a log mode. - The summary follows a real run's rules, with "nothing was run" in place of the successful count and the time saved, and without the `--last-details` hint. The detailed summary (`-v`) has no ✓ or exit codes. Real run, unchanged: ``` vp run: 1/2 cache hit (50%), 2/2 successful. (Run `vp run --last-details` for full details) │ │ │ │ │ │ │ │ │ └─ tasks │ │ │ └─ tasks that succeeded │ │ └─ cache hit rate │ └─ tasks └─ cache hits ``` Dry run: ``` vp run: 1/2 cache hit (50%), nothing was run. │ │ │ │ │ └─ cache hit rate │ └─ tasks └─ cache hits ``` - A cache lookup error is printed under its command and stops the dry run, as it stops a real run, and both exit 1. Real runs stopped but exited 0 before, since the summary only counted tasks that started; a task that fails before it starts now fails the run. Otherwise a dry run exits 0 once planning succeeds. - A nested `vp run --dry-run` isn't inlined. It's started as a process that prints its own dry run, so an enclosing dry run doesn't start it. - Without a task, `--dry-run` is an error, like `vp run -v`. After the task name, it's passed to the task, like any other flag. - RFC: the summary and cache-error rules are written down, and the sentence about the first changed file being the first in path order is removed. Without `-v`, the file check stops at whichever changed file it finds first. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches cache lookup, remote fetch, spawn, and exit-code paths across the runner; mistakes could skip real execution side effects or mis-report failures, though behavior is gated on `RunKind::Dry`. > > **Overview** > Adds **`vp run --dry-run`**, which plans the task graph and performs full cache lookups (including remote) but **does not** spawn processes, replay outputs, download remote archives, write cache entries, or persist `last-summary.json`. > > The CLI introduces **`RunMode`/`RunKind`**: `--dry-run` and `--log` move onto `RunCommand` (dry runs always use interleaved output). Execution and cache layers thread `RunKind` through lookup, spawn, and reporters so dry runs short-circuit after reporting cache status (`WouldSpawn` / `DryRun` not-updated reasons). > > **Output and summary** match a real run’s command lines and cache indicators, but omit `, executing` / `, replaying`, skip extra blank lines, use **“nothing was run”** instead of success/saved time, and omit the `--last-details` hint. **`-v`** detailed summaries drop exit icons and saved-time wording for hits. > > **Bugfix:** runs now **exit 1** when a task’s cache cannot be checked (e.g. DB unreadable), including failures before `start()`; nested `vp run --dry-run` is not inlined. Changelog and dry-run RFC/e2e snapshots document the behavior. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 3010605. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Aaron Reisman <aaron@lifeiscontent.net> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…961) ## Motivation A cache miss reports one reason. When an env var a tool tracks and a file changed together, the summary named only the file. When a task's `input` and `output` settings changed together, it named only `input`. To know whether reverting a change is enough for a hit, you need every change. The dry-run RFC lists command, config and env changes in full, and `--dry-run --json` (#966) will report them. ## Changes A miss is now `CacheMiss::Changed(Comparison { changes })`. It lists every change to: - the command: program, args, cwd; - the task's cache settings: `input`, `output`, `untrackedEnv`; - its envs: `cache.env`, tracked envs and tracked queries. Files still stop at the first change the check finds, until `-v` changes that in #963. Changes are sorted by kind, then by name or path. Duplicates, such as an env that two tracked queries match, are dropped. - The inline reason is the first change. It changes only where the kind order differs from the old priority, such as a program change alongside an env change. Several env changes still read as `envs 'A', 'B' changed`. - The detailed summary prints one change per line, aligned under the first, instead of joining spawn changes with `; `. An `output` change now reads `output configuration changed` there, not `input configuration changed`. Before: ``` [1] app#test: $ vtt print-file test.txt ✓ → Cache miss: input configuration changed ``` After: ``` [1] app#test: $ vtt print-file test.txt ✓ → Cache miss: input configuration changed output configuration changed ``` - The saved summary holds the list, so `vp run --last-details` gives a `last-summary.json` from an earlier version the existing "different version" message. - Each tracked env and query is compared on its own. If one can't be compared, such as a value that isn't UTF-8, another's change still makes it a miss, as before, rather than a failed lookup. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches core cache validation and persisted summary format; behavior is clearer but miss detection and reporting paths changed across local and remote lookups. > > **Overview** > **Cache miss reporting** now collects every difference between the current run and a stored entry, not only the first failure. Misses use `CacheMiss::Changed` with a sorted, deduplicated `Vec<Change>` covering command fields (`program`, `args`, `cwd`), cache settings (`input`, `output`, `untrackedEnv`), fingerprinted and runner-tracked env changes, and still at most one file change (first detected). > > **User-facing output:** the inline line uses the first change in kind order (multiple envs still collapse to `envs 'A', 'B' changed`). `vp run --verbose` / `--last-details` print **each** change on its own indented line instead of joining spawn deltas with `; `. `output` changes are labeled separately from `input`. > > **Implementation:** validation, remote cache resolution, and post-run fingerprint checks were refactored to accumulate `Change` values; persisted `last-summary.json` stores the full list (older summaries no longer load cleanly). E2e fixtures cover combined input/output config and multi-env misses. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ba4db44. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
## Motivation The run plan that `vp run --dry-run --json` will print (#966) uses the same task IDs, paths, `version` and `$schema` copy as `vp run --json`. Moving that code out of the task graph module first keeps the JSON PR about the new document. ## Changes Code moves into `session/json/`, with no behaviour change; `schemas/task-graph.json` and every snapshot are unchanged: - from `task_graph_json/document.rs`: `task_id`, `encode_id_part` and `Version`; - from its `mod.rs`: `path_key`; - from its `schema.rs`: `file_url` and the schema materialization, which now takes the artifact as an argument. `Version` takes its number as a const parameter, `Version<1>` for the task graph, since each document has its own format version: a breaking change to one bumps only its own. The output and schema don't change. The task graph uses the moved code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Pure refactor with tests moved alongside; task graph JSON output and schemas are unchanged per the PR intent. > > **Overview** > Introduces a shared `session/json` module so multiple `vp run` JSON outputs can reuse the same **task IDs**, **workspace-relative paths**, **format `version`**, and **`$schema` materialization** logic instead of duplicating it in the task graph code. > > The task graph JSON path is rewired to import those helpers: `Version` becomes a generic `Version<N>` (still `Version<1>` for the task graph), and task-graph-specific schema wiring now passes its `Artifact` into the shared `schema_url` / `materialize` helpers. **No intended output or schema change**—this is structural prep for additional JSON documents (e.g. dry-run run plan). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e75ba86. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Motivation The JSON reporter for `vp run --dry-run --json` (#966) prints the run's structure: tasks, their dependencies, steps and nested plans, with each step's cache status in place. Today a reporter learns about leaves one at a time, by their display text, which can't tell apart the same task in two nested plans. ## Changes No behaviour change; every snapshot is unchanged. - `GraphExecutionReporter::new_leaf_execution` takes the leaf's `LeafPath`: its `(node, item index)` at each nesting level, outermost first. - The scheduler builds the path as it recurses into nodes, items and nested graphs. - The existing reporters ignore it. The summary reporter passes it to the reporter it wraps. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > API-only refactor with reporters ignoring the new path; snapshots and user-facing output are intended to stay the same. > > **Overview** > Introduces **`LeafPath`** — a stack of `(ExecutionNodeIndex, item index)` pairs — so reporters can tell which graph node and step a leaf came from, including inside nested expanded plans. > > The **scheduler** threads that path from the root (`&[]`) through `execute_expanded_graph`, extending it per node/item and passing it into nested graphs before **`new_leaf_execution`**. The **`GraphExecutionReporter`** API now requires `path` on every leaf reporter creation. > > Existing text reporters **ignore** the path (tests pass empty paths); the **summary** wrapper **forwards** it to the inner reporter. **No intended output change** — this lays groundwork for structured reporting (e.g. dry-run JSON) where display text alone cannot disambiguate duplicate tasks in nested runs. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 797c374. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
## Motivation Since #966, `vp run --dry-run --json` fails for a task whose command runs `vp run …`. The dry-run RFC shows such a step as `expandedFrom` with its own `plan`, so the run plan is a tree, and each nested plan has its own dependencies. ## Changes ```jsonc // "nested": "vp run build" { "expandedFrom": "vp run build", "plan": { "build": { "package": ".", "name": "build", "steps": [ { "program": "…", "cache": { "status": "hit", … } } ] } } } ``` - The layout recurses into nested graphs. Each plan's `dependsOn` is scoped to its own tasks, so the same task ID can appear at several levels. - `expandedFrom` is the item's command as written, with any args given after the task name. - A leaf's step is found by its path through the nested plans. - The error for tasks that run `vp run` goes away. A nested `vp run --dry-run` is still a spawned step, which a dry run doesn't start. The e2e fixture `run_plan_json_nested` covers plans at several levels, args forwarded to a nested run, and a nested dry run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes the `--dry-run --json` output shape and reporting path for nested runs; behavior is additive for consumers that already handle the schema’s `NestedStep`, with new e2e coverage. > > **Overview** > `vp run --dry-run --json` no longer errors when a task’s command is another `vp run`. Those steps are emitted as **nested plan** objects (`expandedFrom` plus an embedded `plan`) instead of plain command steps. > > The run-plan JSON schema and Rust document types split **steps** into **command steps** and **nested steps**, with `dependsOn` scoped per nested plan. The JSON reporter builds plans recursively, tracks step locations through the nesting tree, and still attaches cache status to the right leaf commands. > > Nested `vp run --dry-run` invocations remain ordinary spawned steps (not expanded). Changelog and e2e fixtures document multi-level nesting, forwarded task args, and the removed “unsupported” error. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1e22ef3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Motivation
Coding agents and CI need a dry run's answer as data, without parsing text: which tasks would run, in what order, and why each would hit or miss (#791, voidzero-dev/vite-plus#2848). The dry-run RFC specifies the run plan that
vp run --dry-run --jsonprints, and this PR implements it through a new reporter. For now, a task whose command runsvp runfails and says so; #967 adds nested plans.Changes
--jsonis no longerexclusive. It conflicts with an explicit--log, andRunCommand::resolvechecks the rest once, with clap-style errors.--jsonalone resolves to the task graph, and with--dry-runto a run whoseRunModeisDryJson. With a task but no--dry-run, the error says--jsonis only supported with--dry-runfor now. With other flags and no task, it's the same conflict error as before. Without a task,--dry-run --jsonfails when it's planned, as--dry-rundoes. The session matches on that, so nothing re-checks--jsonlater, andplan_from_cli_runresolves its command the same way. It's never interactive: a task that isn't found is an error on stderr, not the task list on stdout. An empty plan, such as when--filtermatches nothing, prints"plan": {}.Comparisongains the baseline's duration andchanges_partial.changes_partialis set when the file check stopped at the first changed file, or couldn't check some files. After a command, config or env change, only the previous run's key is compared, so the step ischangedwith its key changes,changesPartial, and nobaseline; the RFC'sbaselineis optional for that case. Program, args and cwd changes keep what they changed from and to. vt_plan gets a program accessor on the spawn fingerprint, and name and args accessors on built-ins.session/reporter/json/).dependsOn, and its steps (program,args,cwd,hook).startfills in itscache:hit,changed,noBaseline,errorordisabled, or absent for a built-in.cfg(test). A test regenerates the committedschemas/run-plan.json.artifact!embeds it, and each run copies it to the user's temp folder for$schema, as forvp run --json. Both documents are written by onejson::write_document, which serializes into memory first, so an error partway prints nothing.run_plan_jsoncovers the plan's layout:-redges and--parallel, hooks, programs inside and outside the workspace,--no-cacheand--cache, forwarded args, the shell,cdand thecwdsetting, built-ins, and encoded task IDs.selectioncase covers which tasks are planned: a task that some or all selected packages lack, an unknown package, and a filter that matches nothing, with and without--fail-if-no-match.dry_run_jsoncovers the cache statuses and flags that combine with--dry-run --json, or that are passed to the task when they come after its name.errorscase covers--jsonwith a task but no--dry-run, with--log, with--last-details, or with flags but no task;--dry-run --jsonwithout a task; and a task that isn't found.--json builderror message changes.🤖 Generated with Claude Code
Note
Medium Risk
Touches CLI parsing, session dispatch, and cache comparison shapes used by dry runs and reporters; behavior is well snapshot-tested but flag combinations and cache edge cases warrant review.
Overview
Adds
vp run --dry-run --json, which emits a single run-plan JSON document (tasks,dependsOn, per-step program/args/cwd/hook, and projected cache status) for CI and agents, with a committedschemas/run-plan.jsonand$schemamaterialized like the task graph.CLI:
--jsonis no longer exclusive-only; with a task it requires--dry-run(otherwise a clap-style error). Barevp run --jsonstill dumps the task graph. Resolution flows throughRunCommand::resolve/RunMode::DryJson, and--jsonconflicts with--log.Cache / JSON payload:
ComparisonandChangenow carry baseline duration,changesPartial, and from/to details for program, args, and cwd so misses serialize faithfully; validation returnsCheckedwith partial file lists.Execution path: A new JSON reporter lays out the graph up front, fills cache on each dry leaf
start, writes once at the end (or stderr-only on lookup failure / cancel / nestedvp run, which is rejected). Sharedjson::write_documentand schema snapshot tests cover both JSON outputs.Tests / docs: E2E fixtures for plan layout, cache statuses, flags, and errors; dry-run RFC examples updated for optional baseline and
changesPartial.Reviewed by Cursor Bugbot for commit 220dbb0. Bugbot is set up for automated code reviews on this repo. Configure here.